Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix some wasi_testsuite cases #6343

Merged
merged 2 commits into from
May 5, 2023
Merged

test: fix some wasi_testsuite cases #6343

merged 2 commits into from
May 5, 2023

Commits on May 4, 2023

  1. test: clean up wasi_testsuite test files 

    When running `cargo run wasi_testsuite -- --nocapture`, some test cases
generate files and folders that need to be removed for subsequent test
runs to pass. These paths are all suffixed with `*.cleanup` so we walk
the suite directory before and after execution to clean up these files.
    @abrown
    abrown committed May 4, 2023
    Configuration menu
    Copy the full SHA
    80a62e9 View commit details
    Browse the repository at this point in the history

  2. test: fix how wasi_testsuite maps directories 

    This change fixes how directories are mapped from the host environment
to the WebAssembly guest when the `wasi_testsuite` test is run.
Previously, Wasmtime's `--dir` flag was used which expects the passed
directory to be in the current working directory. In this case, though,
the directories were buried down `tests/wasi-testsuite/wasi-common/...`
so the correct flag is `--mapdir`. Switching to this flag allows a large
number of the ignored tests to now pass.
    @abrown
    abrown committed May 4, 2023
    Configuration menu
    Copy the full SHA
    8bb6085 View commit details
    Browse the repository at this point in the history