Burn down the allow_attributes_without_reason backlog (#9712)

* Burn down the `allow_attributes_without_reason` backlog

Just a bit, not everything fixed.

* Fix wasi-nn annotations

* Tweak `#[cfg]`

benches/call.rs

@@ -1,5 +1,3 @@
-#![expect(clippy::allow_attributes_without_reason, reason = "crate not migrated")]
-
 use criterion::measurement::WallTime;
 use criterion::{criterion_group, criterion_main, BenchmarkGroup, Criterion};
 use std::fmt::Debug;
@@ -445,7 +443,7 @@ trait ToVals {
 
 macro_rules! tuples {
     ($($t:ident)*) => (
-        #[allow(non_snake_case)]
+        #[allow(non_snake_case, reason = "macro-generated code")]
         impl<$($t:Copy + Into<Val>,)*> ToVals for ($($t,)*) {
             fn to_vals(&self) -> Vec<Val> {
                 let mut _dst = Vec::new();
@@ -534,7 +532,7 @@ mod component {
 
     macro_rules! tuples {
         ($($t:ident)*) => (
-            #[allow(non_snake_case)]
+            #[allow(non_snake_case, reason = "macro-generated code")]
             impl<$($t:Copy + ToComponentVal,)*> ToComponentVals for ($($t,)*) {
                 fn to_component_vals(&self) -> Vec<component::Val> {
                     let mut _dst = Vec::new();

cranelift/filetests/src/function_runner.rs

@@ -528,7 +528,10 @@ fn make_trampoline(name: UserFuncName, signature: &ir::Signature, isa: &dyn Targ
 #[cfg(target_arch = "x86_64")]
 use std::arch::x86_64::__m128i;
 #[cfg(target_arch = "x86_64")]
-#[allow(improper_ctypes_definitions)]
+#[expect(
+    improper_ctypes_definitions,
+    reason = "manually verified to work for now"
+)]
 extern "C" fn __cranelift_x86_pshufb(a: __m128i, b: __m128i) -> __m128i {
     union U {
         reg: __m128i,

cranelift/filetests/src/lib.rs

@@ -4,7 +4,6 @@
 //! available filetest commands.
 
 #![deny(missing_docs)]
-#![expect(clippy::allow_attributes_without_reason, reason = "crate not migrated")]
 
 pub use crate::function_runner::TestFileCompiler;
 use crate::runner::TestRunner;

cranelift/filetests/src/subtest.rs

@@ -29,7 +29,7 @@ pub struct Context<'a> {
     pub isa: Option<&'a dyn TargetIsa>,
 
     /// Full path to the file containing the test.
-    #[allow(dead_code)]
+    #[expect(dead_code, reason = "may get used later")]
     pub file_path: &'a str,
 
     /// Context used to update the original `file_path` in-place with its test

cranelift/filetests/src/test_unwind.rs

@@ -108,7 +108,7 @@ mod windowsx64 {
         version: u8,
         flags: u8,
         prologue_size: u8,
-        #[allow(dead_code)]
+        #[expect(dead_code, reason = "may get used later")]
         unwind_code_count_raw: u8,
         frame_register: u8,
         frame_register_offset: u8,

cranelift/frontend/src/lib.rs

@@ -157,10 +157,7 @@
 
 #![deny(missing_docs)]
 #![no_std]
-#![expect(clippy::allow_attributes_without_reason, reason = "crate not migrated")]
 
-#[allow(unused_imports)] // #[macro_use] is required for no_std
-#[macro_use]
 extern crate alloc;
 
 #[cfg(feature = "std")]

cranelift/frontend/src/switch.rs

@@ -348,8 +348,8 @@ mod tests {
                 let block = bx.create_block();
                 bx.switch_to_block(block);
                 let val = bx.ins().iconst(types::I8, 0);
-                #[allow(unused_mut)]
                 let mut switch = Switch::new();
+                let _ = &mut switch;
                 $(
                     let block = bx.create_block();
                     switch.set_entry($index, block);

cranelift/module/src/lib.rs

@@ -2,7 +2,6 @@
 
 #![deny(missing_docs)]
 #![no_std]
-#![expect(clippy::allow_attributes_without_reason, reason = "crate not migrated")]
 
 #[cfg(not(feature = "std"))]
 #[macro_use]

cranelift/module/src/module.rs

@@ -220,12 +220,10 @@ impl From<FuncOrDataId> for ModuleRelocTarget {
     feature = "enable-serde",
     derive(serde_derive::Serialize, serde_derive::Deserialize)
 )]
+#[allow(missing_docs, reason = "self-describing fields")]
 pub struct FunctionDeclaration {
-    #[allow(missing_docs)]
     pub name: Option<String>,
-    #[allow(missing_docs)]
     pub linkage: Linkage,
-    #[allow(missing_docs)]
     pub signature: ir::Signature,
 }
 
@@ -379,14 +377,11 @@ pub type ModuleResult<T> = Result<T, ModuleError>;
     feature = "enable-serde",
     derive(serde_derive::Serialize, serde_derive::Deserialize)
 )]
+#[allow(missing_docs, reason = "self-describing fields")]
 pub struct DataDeclaration {
-    #[allow(missing_docs)]
     pub name: Option<String>,
-    #[allow(missing_docs)]
     pub linkage: Linkage,
-    #[allow(missing_docs)]
     pub writable: bool,
-    #[allow(missing_docs)]
     pub tls: bool,
 }
 

cranelift/reader/src/lexer.rs

@@ -3,8 +3,6 @@
 use crate::error::Location;
 use cranelift_codegen::ir::types;
 use cranelift_codegen::ir::{Block, Value};
-#[allow(unused_imports, deprecated)]
-use std::ascii::AsciiExt;
 use std::str::CharIndices;
 use std::u16;
 

cranelift/reader/src/lib.rs

@@ -4,7 +4,6 @@
 //! testing Cranelift, but is not essential for a JIT compiler.
 
 #![deny(missing_docs)]
-#![expect(clippy::allow_attributes_without_reason, reason = "crate not migrated")]
 
 pub use crate::error::{Location, ParseError, ParseResult};
 pub use crate::isaspec::{parse_option, parse_options, IsaSpec, ParseOptionError};
@@ -30,7 +29,7 @@ use std::str::FromStr;
 use target_lexicon::Triple;
 
 /// Like `FlagsOrIsa`, but holds ownership.
-#[allow(missing_docs)]
+#[allow(missing_docs, reason = "self-describing variants")]
 pub enum OwnedFlagsOrIsa {
     Flags(settings::Flags),
     Isa(OwnedTargetIsa),

cranelift/reader/src/run_command.rs

@@ -105,7 +105,7 @@ impl Display for Invocation {
 }
 
 /// A CLIF comparison operation; e.g. `==`.
-#[allow(missing_docs)]
+#[allow(missing_docs, reason = "self-describing variants")]
 #[derive(Debug, PartialEq)]
 pub enum Comparison {
     Equals,

crates/component-macro/tests/codegen.rs

@@ -1,5 +1,4 @@
-#![allow(dead_code)]
-#![expect(clippy::allow_attributes_without_reason, reason = "crate not migrated")]
+#![allow(dead_code, reason = "lots of macro-generated code")]
 
 macro_rules! gentest {
     ($id:ident $name:tt $path:tt) => {
@@ -135,7 +134,6 @@ mod trappable_errors_with_versioned_and_unversioned_packages {
         },
     });
 
-    #[allow(dead_code)]
     type MyX = u64;
 }
 
@@ -177,7 +175,6 @@ mod trappable_errors {
         },
     });
 
-    #[allow(dead_code)]
     type MyX = u32;
 }
 

crates/wasi-keyvalue/tests/main.rs

@@ -1,5 +1,3 @@
-#![expect(clippy::allow_attributes_without_reason, reason = "crate not migrated")]
-
 use anyhow::{anyhow, Result};
 use test_programs_artifacts::{foreach_keyvalue, KEYVALUE_MAIN_COMPONENT};
 use wasmtime::{
@@ -48,7 +46,7 @@ async fn run_wasi(path: &str, ctx: Ctx) -> Result<()> {
 
 macro_rules! assert_test_exists {
     ($name:ident) => {
-        #[allow(unused_imports)]
+        #[expect(unused_imports, reason = "just here to assert it exists")]
         use self::$name as _;
     };
 }

crates/wasi-nn/tests/check/mod.rs

@@ -4,18 +4,14 @@
 //! - that various backends can be located on the system (see sub-modules)
 //! - that certain ML model artifacts can be downloaded and cached.
 
-#![expect(clippy::allow_attributes_without_reason, reason = "crate not migrated")]
-
-#[allow(unused_imports)]
-use anyhow::{anyhow, Context, Result};
 use std::{
     env,
     path::{Path, PathBuf},
     process::Command,
     sync::Mutex,
 };
 
-#[cfg(any(feature = "onnx", feature = "winml"))]
+#[cfg(any(feature = "onnx", all(feature = "winml", target_os = "windows")))]
 pub mod onnx;
 #[cfg(feature = "openvino")]
 pub mod openvino;

crates/wasi-nn/tests/check/onnx.rs

@@ -1,8 +1,5 @@
-#![allow(unused)]
-
 use super::{artifacts_dir, download, DOWNLOAD_LOCK};
 use anyhow::{Context, Result};
-use std::sync::Mutex;
 use std::{env, fs};
 
 /// Return `Ok` if we find the cached MobileNet test artifacts; this will

examples/mpk.rs

@@ -31,8 +31,6 @@
 //! $ sysctl vm.max_map_count=$LARGER_LIMIT
 //! ```
 
-#![expect(clippy::allow_attributes_without_reason, reason = "crate not migrated")]
-
 use anyhow::anyhow;
 use bytesize::ByteSize;
 use clap::Parser;
@@ -115,7 +113,6 @@ fn probe_engine_size(args: &Args, mpk: MpkEnabled) -> Result<Pool> {
 }
 
 #[derive(Debug)]
-#[allow(dead_code)]
 struct Pool {
     num_memories: u32,
     mapped_bytes: usize,