Prepare to update spec test suite #1909
Open
+45
−195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some minor updates in preparation for WebAssembly/testsuite#110: * Don't limit the size of tables in the validator and instead defer such maximal validation to runtimes themselves. * Parse the `(pagesize N)` syntax on "inline memories" * Always parse table/memory limits as 64-bit integers * Stop matching spec test suite error messages This last point is something I've tried to hold off on doing for a long time but as the giant `error_matches` function continues to grow and become more unwieldy it has become less and less tenable to do this. Overall it doesn't seem too beneficial to keep maintaining this especially in the face of numerous proposals, so instead basically remove it entirely.
pchickey
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor updates in preparation for WebAssembly/testsuite#110:
(pagesize N)syntax on "inline memories"This last point is something I've tried to hold off on doing for a long time but as the giant
error_matchesfunction continues to grow and become more unwieldy it has become less and less tenable to do this. Overall it doesn't seem too beneficial to keep maintaining this especially in the face of numerous proposals, so instead basically remove it entirely.