Emit byte for extracting to IP #3906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zzzabiyaka
requested review from
loganek,
lum1n0us,
no1wudi,
wenyongh,
xujuntwt95329 and
yamt
as code owners
loganek
approved these changes
Nov 12, 2024
Zzzabiyaka
force-pushed
the
emit_byte_ip
branch
from
8c8d6be
to
7ce9fb5
Compare
xujuntwt95329
approved these changes
Nov 13, 2024
lum1n0us
merged commit fbbcd08
into
bytecodealliance:dev/simd_for_interp
382 of 383 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it looks like this was missing as I wasn't able to read the imm for frame_ip[0] when implementing extract lane for fast interpreter
after this fix it is propagated correctly