Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): Remove float-abi flag #3889

Merged
merged 1 commit into from
Oct 29, 2024
Merged

fix(ios): Remove float-abi flag #3889

merged 1 commit into from
Oct 29, 2024

Conversation

xdoardo
Copy link
Contributor

@xdoardo xdoardo commented Oct 28, 2024

Compiling wamr targeting iOS results in

clang: error: unsupported option '-mfloat-abi=' for target 'aarch64-apple-ios'

This small patch removes this setting in the related CMakeLists.txt file.

@xdoardo xdoardo mentioned this pull request Oct 28, 2024
Merged
lum1n0us
lum1n0us approved these changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@lum1n0us lum1n0us left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lum1n0us lum1n0us merged commit a713ba1 into bytecodealliance:main Oct 29, 2024
383 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lum1n0us lum1n0us lum1n0us approved these changes

@wenyongh wenyongh wenyongh approved these changes

@loganek loganek Awaiting requested review from loganek loganek is a code owner

@no1wudi no1wudi Awaiting requested review from no1wudi no1wudi is a code owner

@xujuntwt95329 xujuntwt95329 Awaiting requested review from xujuntwt95329 xujuntwt95329 is a code owner

@yamt yamt Awaiting requested review from yamt yamt is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xdoardo @wenyongh @lum1n0us