Enable running spec tests on Windows #2423
Conversation
loganek
force-pushed
the
loganek/enable-testsuite
branch
7 times, most recently
from
4648d85
to
5e9ec5c
Compare
loganek
changed the title
loganek
force-pushed
the
loganek/enable-testsuite
branch
2 times, most recently
from
7835754
to
1a482d6
Compare
|
@wenyongh looks like the build failure is not related to this change. Could we possibly rebase the |
loganek
force-pushed
the
loganek/enable-testsuite
branch
from
1a482d6
to
2d5fa99
Compare
loganek
force-pushed
the
loganek/enable-testsuite
branch
4 times, most recently
from
2840912
to
4119205
Compare
|
Thanks a lot @wenyongh , the PR is now ready for review. |
We don't enable those tests in CI yet as not all of them are passing
loganek
force-pushed
the
loganek/enable-testsuite
branch
2 times, most recently
from
7315912
to
68b6708
Compare
| @@ -101,35 +135,53 @@ def __init__(self, args, no_pty=False): | |||
| self.stdin = os.fdopen(master, 'r+b', 0) | |||
| self.stdout = self.stdin | |||
|
|
|||
| if platform.system().lower() == "windows": | |||
There was a problem hiding this comment.
Just be curious, is it possible to have a cross-platform solution for reading stdout?
There was a problem hiding this comment.
Good question. The only cross-platform I could think of was by using a thread and a queue (just like it was implemented in this PR for Windows); but I did not use this technique for other operating systems because it turned to be significantly (2 - 3 x) slower, so I kept the approach with select for non-windows platforms.
wenyongh
merged commit ea76300
into
bytecodealliance:dev/wasi-libc-windows
Update wamr-test-suites scripts to enable running spec tests on Windows. We don't enable those tests in CI yet as not all of them are passing.
We don't enable those tests in CI yet as not all of them are passing