nightly compiler/lint fixes #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this. I think the best way to address it is not use nightly to run the lints. Clippy changes frequently in nightly -- and often in ways that never get stabilized. We shouldn't have to worry about that and constantly make changes to keep up. I'll see what I can do to fix the GitHub workflows to use stable by default. As I mentioned elsewhere, we only need nightly for building the runtime library, and once #113 is addressed we might not need it at all anymore. |
|
Oops, forget what I said above. Looks like these lints are on stable after all; I just hadn't updated locally yet. And it seems that CI is using stable by default, so that's good. |
dicej
approved these changes
Dec 5, 2024
Merged
philrhc
added a commit
to philrhc/componentize-py
that referenced
this pull request
Dec 6, 2024
* test * trigger test workflow * remove lint from workflow * lint/compiler fixes * re-adds readme --------- Co-authored-by: Phil Cummins <[email protected]>
dicej
pushed a commit
that referenced
this pull request
Dec 6, 2024
* refactors linking * remove , anyhow::Error from prelink * fmt * formatting * nightly compiler/lint fixes (#129) * test * trigger test workflow * remove lint from workflow * lint/compiler fixes * re-adds readme --------- Co-authored-by: Phil Cummins <[email protected]> --------- Co-authored-by: Phil Cummins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i think that main branch is breaking as rustc nightly is being updated