-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(guild): implement onboarding #1401
Conversation
I could have done a rebase, but whatever 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, changes are good to go, however, a few tweaks are required.
Thanks for the feedback, I appreciate your time on this. I'm currently on vacation and will get to it in a week or two. |
Add constants defining onboarding modes and Mode field to GuildOnboarding.
I should now have addressed all your feedback. |
Co-authored-by: Fedor Lapshin <[email protected]>
6d599b3
to
34f0fa5
Compare
Make Prompts field a pointer to allow removing all the prompts.
Use GuildOnboardingMode type in GuildOnboardingModeDefault and GuildOnboardingModeAdvanced.
Sorry it took so long! Decided to make some of the changes myself, hopefully you don't mind. |
6534548
to
bbc87b0
Compare
The related endpoint ignores the null value for this field. Thus the pointer can be dropped.
bbc87b0
to
b4d6804
Compare
Implement emoji_id, emoji_name and emoji_animated fields for usage in creation and update requests.
Well, a lot of changes. Want to merge this into the next release I'm going to make soon. So decided to take it upon myself to finish the PR. |
Thanks for your contribution! |
Much appreciated for pushing this over the finish line. My bad for not keeping up here but I pretty quickly found another way to better achieve what I wanted through role flags (#1410) so this wasn't as relevant to me anymore. Very nice to hear about a potential new release soonish. |
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/bwmarrin/discordgo](https://togithub.com/bwmarrin/discordgo) | `v0.27.1` -> `v0.28.1` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fbwmarrin%2fdiscordgo/v0.28.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fbwmarrin%2fdiscordgo/v0.28.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fbwmarrin%2fdiscordgo/v0.27.1/v0.28.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fbwmarrin%2fdiscordgo/v0.27.1/v0.28.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>bwmarrin/discordgo (github.com/bwmarrin/discordgo)</summary> ### [`v0.28.1`](https://togithub.com/bwmarrin/discordgo/releases/tag/v0.28.1): DiscordGo v0.28.1 [Compare Source](https://togithub.com/bwmarrin/discordgo/compare/v0.28.0...v0.28.1) Hi all! This release, once again, only bumps semantic version of the library and does not contain any new fixes nor features. Sorry for the inconvenience! See previous release for changelog. ### [`v0.28.0`](https://togithub.com/bwmarrin/discordgo/releases/tag/v0.28.0): DiscordGo v0.28.0 [Compare Source](https://togithub.com/bwmarrin/discordgo/compare/v0.27.1...v0.28.0) ##### Changelog ##### Breaking changes - `ChannelEdit.Position` is now a pointer [https://github.com/bwmarrin/discordgo/pull/1385](https://togithub.com/bwmarrin/discordgo/pull/1385) - `Button.Emoji` is now a pointer [https://github.com/bwmarrin/discordgo/pull/1475](https://togithub.com/bwmarrin/discordgo/pull/1475) - `SelectMenuOption.Emoji` is now a pointer [https://github.com/bwmarrin/discordgo/pull/1476](https://togithub.com/bwmarrin/discordgo/pull/1476) - `Components` and `Embeds` in `MessageEdit` are now pointers [https://github.com/bwmarrin/discordgo/pull/1483](https://togithub.com/bwmarrin/discordgo/pull/1483) - `WebhookEdit` and `WebhookEditWithToken` now return `*Webhook`, instead of `*Role` [https://github.com/bwmarrin/discordgo/pull/1497](https://togithub.com/bwmarrin/discordgo/pull/1497) - `AuditLogGuildScheduledEventUpdare` was renamed to `AuditLogGuildScheduledEventUpdate` [https://github.com/bwmarrin/discordgo/pull/1370](https://togithub.com/bwmarrin/discordgo/pull/1370) - Type of `Message.StickerItems` was changed to `[]StickerItem` [https://github.com/bwmarrin/discordgo/pull/1494](https://togithub.com/bwmarrin/discordgo/pull/1494) - `withMember` parameter was added to `Session.ThreadMember` and `Session.ThreadMembers` [https://github.com/bwmarrin/discordgo/pull/1325](https://togithub.com/bwmarrin/discordgo/pull/1325) - `limit` parameter was added to `Session.ThreadMembers` [https://github.com/bwmarrin/discordgo/pull/1325](https://togithub.com/bwmarrin/discordgo/pull/1325) ##### Features - Onboarding [https://github.com/bwmarrin/discordgo/pull/1401](https://togithub.com/bwmarrin/discordgo/pull/1401) - Default values for auto-populated select menus [https://github.com/bwmarrin/discordgo/pull/1452](https://togithub.com/bwmarrin/discordgo/pull/1452) - Role icons [https://github.com/bwmarrin/discordgo/pull/1334](https://togithub.com/bwmarrin/discordgo/pull/1334) ##### Additions - Add support for usernames without disciminator [https://github.com/bwmarrin/discordgo/pull/1387](https://togithub.com/bwmarrin/discordgo/pull/1387) - Add `WebhookParams.ThreadName` [https://github.com/bwmarrin/discordgo/pull/1412](https://togithub.com/bwmarrin/discordgo/pull/1412) - Add `SuppressNotification` and `IsVoiceMessage` message flags [https://github.com/bwmarrin/discordgo/pull/1428](https://togithub.com/bwmarrin/discordgo/pull/1428) - Add `MessageSend.Flags` [https://github.com/bwmarrin/discordgo/pull/1427](https://togithub.com/bwmarrin/discordgo/pull/1427) - Add `FailIfNotExists` and `SoftReference` to `Message` [https://github.com/bwmarrin/discordgo/pull/1376](https://togithub.com/bwmarrin/discordgo/pull/1376) - Add `MessageSend.StickerIDs` [https://github.com/bwmarrin/discordgo/pull/1340](https://togithub.com/bwmarrin/discordgo/pull/1340) - Add `ApplicationCommandInteractionData.CommandType` [https://github.com/bwmarrin/discordgo/pull/1362](https://togithub.com/bwmarrin/discordgo/pull/1362) - Add `AuditLogOptions.IntegrationType` [https://github.com/bwmarrin/discordgo/pull/1440](https://togithub.com/bwmarrin/discordgo/pull/1440) - Add `AuditLogOptions.ApplicationID` [https://github.com/bwmarrin/discordgo/pull/1380](https://togithub.com/bwmarrin/discordgo/pull/1380) - Add auto moderation audit log actions and options [https://github.com/bwmarrin/discordgo/pull/1371](https://togithub.com/bwmarrin/discordgo/pull/1371) - Add monetization audit log actions [https://github.com/bwmarrin/discordgo/pull/1442](https://togithub.com/bwmarrin/discordgo/pull/1442) - Add `BotHTTPInteractions` and `ActiveBotDeveloper` user flags [https://github.com/bwmarrin/discordgo/pull/1465](https://togithub.com/bwmarrin/discordgo/pull/1465) - Add `ThreadMember.Member` [https://github.com/bwmarrin/discordgo/pull/1325](https://togithub.com/bwmarrin/discordgo/pull/1325) - Add `Member.Flags` [https://github.com/bwmarrin/discordgo/pull/1499](https://togithub.com/bwmarrin/discordgo/pull/1499) - Add `Member.DisplayName` [https://github.com/bwmarrin/discordgo/pull/1426](https://togithub.com/bwmarrin/discordgo/pull/1426) - Add `Attachments` to `InteractionResponseData`, `WebhookEdit` and `WebhookParams` [https://github.com/bwmarrin/discordgo/pull/1392](https://togithub.com/bwmarrin/discordgo/pull/1392) - Add `Session.ShouldReconnectVoiceOnSessionError` [https://github.com/bwmarrin/discordgo/pull/1350](https://togithub.com/bwmarrin/discordgo/pull/1350) - Add `Role.Flags` [https://github.com/bwmarrin/discordgo/pull/1410](https://togithub.com/bwmarrin/discordgo/pull/1410) - Add `UpdateCustomStatus` [https://github.com/bwmarrin/discordgo/pull/1425](https://togithub.com/bwmarrin/discordgo/pull/1425) - Add Spanish LATAM locale [https://github.com/bwmarrin/discordgo/pull/1496](https://togithub.com/bwmarrin/discordgo/pull/1496) - Add `GuildDirectory` and `GuildMedia` channel types [https://github.com/bwmarrin/discordgo/pull/1514](https://togithub.com/bwmarrin/discordgo/pull/1514) ##### Other changes - Fix error shadowing in `WebhookEditWithToken` [https://github.com/bwmarrin/discordgo/pull/1372](https://togithub.com/bwmarrin/discordgo/pull/1372) - Remove remove duplicated slash in `EndpointGuildTemplate` [https://github.com/bwmarrin/discordgo/pull/1395](https://togithub.com/bwmarrin/discordgo/pull/1395) - Fix incorrect `AuditLogOptionsType` values [https://github.com/bwmarrin/discordgo/pull/1413](https://togithub.com/bwmarrin/discordgo/pull/1413) - Allow `Components` and `Embeds` in `MessageEdit` to be set to `[]` [https://github.com/bwmarrin/discordgo/pull/1483](https://togithub.com/bwmarrin/discordgo/pull/1483) - Allow `ChannelEdit.Position` to be set to `0` [https://github.com/bwmarrin/discordgo/pull/1385](https://togithub.com/bwmarrin/discordgo/pull/1385) - Fix `BUTTON_COMPONENT_INVALID_EMOJI` error for `Button` [https://github.com/bwmarrin/discordgo/pull/1475](https://togithub.com/bwmarrin/discordgo/pull/1475) - Fix `BUTTON_COMPONENT_INVALID_EMOJI` error for `SelectMenuOption` [https://github.com/bwmarrin/discordgo/pull/1476](https://togithub.com/bwmarrin/discordgo/pull/1476) ##### Special thanks - [@​Roolps](https://togithub.com/Roolps) - [@​tckthecreator](https://togithub.com/tckthecreator) - [@​quackduck](https://togithub.com/quackduck) - [@​Earlopain](https://togithub.com/Earlopain) - [@​loghinalexandru](https://togithub.com/loghinalexandru) - [@​merlinfuchs](https://togithub.com/merlinfuchs) - [@​Aldiwildan77](https://togithub.com/Aldiwildan77) - [@​Ju0x](https://togithub.com/Ju0x) - [@​JulienTant](https://togithub.com/JulienTant) - [@​KokeCacao](https://togithub.com/KokeCacao) - [@​SamusAranX](https://togithub.com/SamusAranX) - [@​TheGrandPackard](https://togithub.com/TheGrandPackard) - [@​phamill](https://togithub.com/phamill) - [@​AlexeyOplachko](https://togithub.com/AlexeyOplachko) - [@​Cyb3r-Jak3](https://togithub.com/Cyb3r-Jak3) - [@​joshuasing](https://togithub.com/joshuasing) - [@​hhaste](https://togithub.com/hhaste) **Full Changelog**: bwmarrin/discordgo@v0.27.1...v0.28.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ymotongpoo/opentelemetry-collector-extra). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zODguMSIsInVwZGF0ZWRJblZlciI6IjM3LjM4OC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Adds support for inspecting the onboarding configuration of a guild.
https://discord.com/developers/docs/resources/guild#guild-onboarding-object
I want to know which roles are assignable by users through onboarding, which this is needed for.