Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Github CI versions #1381

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Update Github CI versions #1381

wants to merge 8 commits into from

Conversation

Earlopain
Copy link
Contributor

  • Remove unused travis config
  • Bump the actions in the workflow file
  • Add Go 1.19 and 1.20 to the test matrix. I added quotes around the versions because 1.20 is being interpreted as 1.2 otherwise
  • Bump the linter and apply needed formatting changes. I can't tell how some of these changes would be rendered in the docs, I just went with what the formatted wanted.

@Earlopain Earlopain changed the title Ci update Update Github CI versions May 14, 2023
@FedorLap2006 FedorLap2006 added the meta Documentation and examples related issues and pull requests label Jul 1, 2023
@Earlopain
Copy link
Contributor Author

Redid on top of current master

@Earlopain
Copy link
Contributor Author

Rebased again, added Go 1.22

FedorLap2006
FedorLap2006 requested changes Jul 7, 2024
View reviewed changes
Copy link
Collaborator

@FedorLap2006 FedorLap2006 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove formatting changes.

@Earlopain
Copy link
Contributor Author

I'm fairly sure the formatting changes are required by bumping golangci-lint. If you don't want that I can drop it, I will make a new PR in that case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FedorLap2006 FedorLap2006 FedorLap2006 requested changes

Assignees
No one assigned
Labels
meta Documentation and examples related issues and pull requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Earlopain @FedorLap2006