Skip to content
This repository has been archived by the owner on Dec 22, 2024. It is now read-only.

Commit

Permalink
Add node version to the github pipeline
Browse files Browse the repository at this point in the history
  • Loading branch information
burakince committed Dec 7, 2024
1 parent 19e93d4 commit ce64b86
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 2 deletions.
4 changes: 4 additions & 0 deletions .github/workflows/docker-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,10 @@ jobs:
- name: Checkout repository
uses: actions/checkout@v4

- uses: actions/setup-node@v4
with:
node-version-file: '.nvmrc'

- name: Install ORAS
id: install_oras
uses: oras-project/setup-oras@main
Expand Down
1 change: 1 addition & 0 deletions .nvmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
22
5 changes: 3 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
FROM node:16.20.2 as foundation
ARG NODE_VERSION=22
FROM node:${NODE_VERSION} as foundation

Check warning on line 2 in Dockerfile

View workflow job for this annotation

GitHub Actions / build

The 'as' keyword should match the case of the 'from' keyword

FromAsCasing: 'as' and 'FROM' keywords' casing do not match More info: https://docs.docker.com/go/dockerfile/rule/from-as-casing/

LABEL maintainer="Burak Ince <[email protected]>"

Expand All @@ -9,7 +10,7 @@ COPY package.json package-lock.json /usr/app/
RUN npm config set loglevel error
RUN npm install

FROM node:16.20.2-slim
FROM node:${NODE_VERSION}-slim

WORKDIR /usr/app

Expand Down

0 comments on commit ce64b86

Please sign in to comment.