make SDK work again. (bunq/sdk_java#148) #149
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To me it's somewhat unclear why it doesn't work, seems that generated objects have changed and actually break some things? With these changes, at least everything compiles, and all test pass Applied the changed related to `ShareInviteBankInquiry` and `ShareDraftInquiry`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes/fixes the following issues:
With this PR, at least the SDK compiles again. It solves the current issues in some of the generated files (which I can not really solve, as these will be regenerated soon).
NotificationFilter*classesShareInviteBankInquiryandShareDraftInquiryas described In the changelog.I understand that you cannot merge this PR as is, but I'd like to hear whether and/or how you'd be able to make the SDK work again? I am hoping to see some dependency updates happening to this SDK soon, as there's quite some outdated ones, and my integration project can't be updated because of clashes with versions from okio httpclient.