Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to override the agent endpoint URL via flag and env var #203

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

wolfeidau
Copy link
Contributor

@wolfeidau wolfeidau commented Jan 20, 2025

I have this new endpoint in a way that always defaults to https://agent.buildkite.com/v3 if not provided to ensure compability with old installations or forks.

I used AgentEndpoint for the param name in the template as it matches the name in the elastic stack template.

@wolfeidau wolfeidau requested a review from DrJosh9000 January 20, 2025 05:27
Copy link
Contributor

@DrJosh9000 DrJosh9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@wolfeidau wolfeidau merged commit 065728a into master Jan 20, 2025
1 check passed
@wolfeidau wolfeidau deleted the feat_allow_override_of_agent_endpoint branch January 20, 2025 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants