Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added dockerfile #77

Merged
merged 2 commits into from
May 5, 2019
Merged

feat: added dockerfile #77

merged 2 commits into from
May 5, 2019

Conversation

amalucelli
Copy link
Contributor

@amalucelli amalucelli commented Apr 4, 2019 •
edited
Loading

Related to #51, I added a base Dockerfile to create a local image for the buildkite-agent-metrics.

@amalucelli amalucelli mentioned this pull request Apr 4, 2019
Open
@lox
Copy link
Contributor

lox commented Apr 30, 2019

How about we do this as a multi-stage Dockerfile? That way we can auto-build it on DockerHub.

@amalucelli
Copy link
Contributor Author

Good idea! I already made the changes for that, thanks!

@lox
Copy link
Contributor

lox commented May 5, 2019

Thanks!

@lox lox merged commit 33adac4 into buildkite:master May 5, 2019
@amalucelli amalucelli deleted the dockerfile branch May 5, 2019 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amalucelli @lox