Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

performance-guideline for rust #8684

Merged
merged 1 commit into from
Dec 11, 2024
Merged

performance-guideline for rust #8684

merged 1 commit into from
Dec 11, 2024

Conversation

davide-baldo
Copy link
Member

No description provided.

@davide-baldo davide-baldo requested a review from a team as a code owner December 2, 2024 11:16
@davide-baldo davide-baldo changed the title feat(rust): added a performance-guideline for rust performance-guideline for rust Dec 2, 2024
@davide-baldo davide-baldo force-pushed the davide-baldo/performance-guideline branch from 3efd7b6 to 0fb9837 Compare December 2, 2024 11:31
SanjoDeundiak
SanjoDeundiak reviewed Dec 2, 2024
View reviewed changes
Copy link
Member

@SanjoDeundiak SanjoDeundiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing that!

implementations/rust/performance-guideline.md Outdated Show resolved Hide resolved
implementations/rust/performance-guideline.md Outdated Show resolved Hide resolved
implementations/rust/performance-guideline.md Outdated Show resolved Hide resolved
@adrianbenavides
Copy link
Member

Awesome content, thanks for putting it together! 🙏

@davide-baldo davide-baldo force-pushed the davide-baldo/performance-guideline branch from 0fb9837 to 70f8dc8 Compare December 10, 2024 11:08
@davide-baldo
Copy link
Member Author

In the last push I also removed the section about the implicit error conversion with ok_or, the semantic of rust shouldn't allow any implicit allocation. Even if the current behavior is "broken", it's probably a situational compiler issue.

@davide-baldo davide-baldo force-pushed the davide-baldo/performance-guideline branch from 70f8dc8 to e51a651 Compare December 11, 2024 13:26
@SanjoDeundiak SanjoDeundiak added this pull request to the merge queue Dec 11, 2024
Merged via the queue into develop with commit d1124b2 Dec 11, 2024
22 checks passed
@SanjoDeundiak SanjoDeundiak deleted the davide-baldo/performance-guideline branch December 11, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SanjoDeundiak SanjoDeundiak SanjoDeundiak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davide-baldo @adrianbenavides @SanjoDeundiak