Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rust): log commands by default to a file #8285

Merged
merged 3 commits into from
Jul 11, 2024

Conversation

etorreborre
Copy link
Member

This PR stores the command logs in a new OCKAM_HOME/commands directory for later diagnostic.
If one wants to get the logs printed in the console directly, it is still possible to use -v to do so.

@etorreborre etorreborre requested a review from a team as a code owner July 10, 2024 16:54
@etorreborre etorreborre self-assigned this Jul 10, 2024
@etorreborre etorreborre enabled auto-merge July 11, 2024 08:34
and only use colors if logs are not directed to a file
@etorreborre etorreborre added this pull request to the merge queue Jul 11, 2024
@etorreborre etorreborre removed this pull request from the merge queue due to a manual request Jul 11, 2024
@etorreborre etorreborre force-pushed the etorreborre/feat/command-logging branch 3 times, most recently from bd9c3a7 to e782c71 Compare July 11, 2024 11:14
@etorreborre etorreborre force-pushed the etorreborre/feat/command-logging branch from e782c71 to b0dedff Compare July 11, 2024 12:33
and use the quiet flag to suppress output messages if necessary
@etorreborre etorreborre force-pushed the etorreborre/feat/command-logging branch from b0dedff to be94dc7 Compare July 11, 2024 12:34
@etorreborre etorreborre added this pull request to the merge queue Jul 11, 2024
Merged via the queue into develop with commit 6c4e1ac Jul 11, 2024
27 checks passed
@etorreborre etorreborre deleted the etorreborre/feat/command-logging branch July 11, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants