fix code to pass cpu.rs module test at ch3.3 #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ichn-hu
reviewed
Oct 24, 2024
| @@ -229,7 +229,7 @@ impl CPU { | |||
|
|
|||
| pub fn load_and_run(&mut self, program: Vec<u8>) { | |||
| self.load(program); | |||
| self.reset(); | |||
| self.program_counter = self.mem_read_u16(0xFFFC); | |||
There was a problem hiding this comment.
you don't have to hack load_and_run to make test past, you can use load, reset and run separately in the test case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to be honest , I do not think we should put reset() in load_and_run() at this chapter other features were not implemented currently, after load the program , if we force cpu reset,all the pre-configured parameter like prgrame file , register statu,will all be lost,definitely we can't pass any test. so I suggest change the code.
After the change test result will pass.
The test result as below