Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better HTTP/SMTP Multipart parsing #128

Merged
merged 2 commits into from
Jun 23, 2024
Merged

Better HTTP/SMTP Multipart parsing #128

merged 2 commits into from
Jun 23, 2024

Conversation

roxblnfk
Copy link
Member

@roxblnfk roxblnfk commented Jun 23, 2024

What was changed

Fix parsing for multipart/mixed data when:

  • There is trailing dot (.) in raw data. In this case connection was frozen.
  • A multipart field doesn't contain Content-Disposition header. In this case parser just failed and zero chunks was parsed.

Related with buggregator/server#213

@roxblnfk roxblnfk added the bug Something isn't working label Jun 23, 2024
@github-actions github-actions bot added the tests Changes in the tests label Jun 23, 2024
@roxblnfk roxblnfk added this to the 1.10.1 milestone Jun 23, 2024
Copy link

codecov bot commented Jun 23, 2024

Codecov Report

Attention: Patch coverage is 58.82353% with 14 lines in your changes missing coverage. Please review.

Project coverage is 22.72%. Comparing base (da9a205) to head (4ed68e0).

Files Patch % Lines
src/Traffic/Parser/MultipartType.php 0.00% 14 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     buggregator/frontend#128      +/-   ##
============================================
+ Coverage     22.70%   22.72%   +0.02%     
- Complexity     1333     1335       +2     
============================================
  Files           156      157       +1     
  Lines          4158     4176      +18     
============================================
+ Hits            944      949       +5     
- Misses         3214     3227      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@roxblnfk roxblnfk merged commit 283740b into master Jun 23, 2024
21 of 23 checks passed
@roxblnfk roxblnfk deleted the fix-smtp-parsing branch June 23, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tests Changes in the tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant