Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Python 3.8 support #1225

Merged
merged 4 commits into from
Jan 15, 2025
Merged

Drop Python 3.8 support #1225

merged 4 commits into from
Jan 15, 2025

Conversation

stefanvanburen
Copy link
Member

No description provided.

@stefanvanburen
Copy link
Member Author

(Trying to see if CI will exercise the Dockerfile changes...)

@stefanvanburen stefanvanburen mentioned this pull request Jan 14, 2025
Closed
@stefanvanburen
Add python3-pip and drop easy_install
b48fb10 
`easy_install` wasn't working; let's just add this dep.
@stefanvanburen
Copy link
Member Author

I've locally tested that the Dockerfile still builds with docker build ., but I don't think it's actually confirmed anywhere in CI. Should be fine.

@stefanvanburen stefanvanburen marked this pull request as ready for review January 15, 2025 15:38
pkwarren
pkwarren reviewed Jan 15, 2025
View reviewed changes
Copy link
Member

@pkwarren pkwarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the Makefile still uses python3.8 too - should that be upgraded?

@stefanvanburen stefanvanburen enabled auto-merge (squash) January 15, 2025 21:26
@stefanvanburen stefanvanburen merged commit 74f67b9 into main Jan 15, 2025
4 checks passed
@stefanvanburen stefanvanburen deleted the svanburen/drop-python-3.8 branch January 15, 2025 21:46
stefanvanburen added a commit that referenced this pull request Jan 22, 2025
@stefanvanburen
Fix Python3.9 build
ed57a51 
This fixes the python3.9 build by installing the pip requirements with
python3.9 and ensuring python3.9-venv is installed.

Follow up to #1225.
@stefanvanburen stefanvanburen mentioned this pull request Jan 22, 2025
Merged
nicksnyder pushed a commit that referenced this pull request Jan 22, 2025
@stefanvanburen
Fix Python3.9 build (#1232)
7b06248 
This fixes the python3.9 build by installing the pip requirements with
python3.9 and ensuring python3.9-venv is installed.

Follow up to #1225.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkwarren pkwarren pkwarren approved these changes

@rodaine rodaine Awaiting requested review from rodaine

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefanvanburen @pkwarren