Update cc_proto to 0.1.0 and remove rules_proto dep #1210
Closed
+124
−85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes bufbuild#1199 rules_proto has been deprecated and should no longer be used. rules_cc removed the proto-related bazel rules as of 0.1.0. Instead, these rules now live in com_google_protobuf and should be used from there. Several other dependencies also had to be updated to support the changes in com_google_protobuf and cc_proto.
|
|
|
To give some context for the motivation behind this: This is currently causing errors for anything that depends on both protobuf and boost from the Bazel Central Registry when building with bzlmod. The reason is due to the fact that a bunch of the boost libraries which were released on the BCR already depend on rules_cc v0.1.0. |
nicksnyder
requested review from
jchadwick-buf
and removed request for
jchadwick-buf
|
FYI build is red so we can't consider merging this. |
|
I'm going to close this for now. It looks like rules_cc 0.1.0 was yanked, precisely to alleviate the urgency of this type of migration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1199
rules_proto has been deprecated and should no longer be used.
rules_cc removed the proto-related bazel rules as of 0.1.0. Instead, these rules now live in com_google_protobuf and should be used from there.
Several other dependencies also had to be updated to support the changes in com_google_protobuf and cc_proto.