Skip to content

Commit

Permalink
Bump required python version to 3.9 everywhere
Browse files Browse the repository at this point in the history
  • Loading branch information
stefanvanburen committed Jan 15, 2025
1 parent b48fb10 commit d849561
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
8 changes: 4 additions & 4 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -143,14 +143,14 @@ prepare-python-release:
.PHONY: python-release
python-release: prepare-python-release
rm -rf python/dist
python3.8 -m build --no-isolation --sdist python
# the below command should be identical to `python3.8 -m build --wheel`
python3.9 -m build --no-isolation --sdist python
# the below command should be identical to `python3.9 -m build --wheel`
# however that returns mysterious `error: could not create 'build': File exists`.
# setuptools copies source and data files to a temporary build directory,
# but why there's a collision or why setuptools stopped respecting the `build_lib` flag is unclear.
# As a workaround, we build a source distribution and then separately build a wheel from it.
python3.8 -m pip wheel --wheel-dir python/dist --no-deps python/dist/*
python3.8 -m twine upload --verbose --skip-existing --repository ${PYPI_REPO} --username "__token__" --password ${PGV_PYPI_TOKEN} python/dist/*
python3.9 -m pip wheel --wheel-dir python/dist --no-deps python/dist/*
python3.9 -m twine upload --verbose --skip-existing --repository ${PYPI_REPO} --username "__token__" --password ${PGV_PYPI_TOKEN} python/dist/*

.PHONY: check-generated
check-generated: ## run during CI; this checks that the checked-in generated code matches the generated version.
Expand Down
2 changes: 1 addition & 1 deletion python/setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ install_requires =
Jinja2>=2.11.1
protobuf>=5.27.0
astunparse>=1.6.3; python_version<"3.10"
python_requires = >=3.6
python_requires = >=3.9

[options.data_files]
data = validate.proto
Expand Down

0 comments on commit d849561

Please sign in to comment.