Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BA-639 Add set articles to KlarnaKP Pay function #80

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

gijsmin
Copy link
Contributor

@gijsmin gijsmin commented Nov 27, 2024

This code adds the possibility to sent an optional list of articles together with the KlarnaKP pay request.

@gijsmin
Copy link
Contributor Author

gijsmin commented Nov 27, 2024

It looks like this needs some more work from the Buckaroo side, since sending a list of articles with the pay request results in incomplete requests from Buckaroo to Klarna:

"Services": {
    "ServiceList": [
      {
        "Action": "Pay",
        "Name": "klarnakp",
        "Version": 1,
        "Parameters": [
          {
            "Name": "ReservationNumber",
            "Value": "fe11d0f9-dce4-4188-9ad0-9e32e19d0038"
          },
          {
            "Name": "Identifier",
            "Value": "H131365"
          },
          {
            "Name": "Type",
            "Value": "General"
          },
          {
            "Name": "Price",
            "Value": 139.99
          },
          {
            "Name": "Quantity",
            "Value": 1
          },
          {
            "Name": "VatPercentage",
            "Value": 19
          },
       ]
}

@Buckaroo-Rene Buckaroo-Rene self-assigned this Nov 27, 2024
@Buckaroo-Rene
Copy link
Contributor

Good morning @gijsmin,

Thank you very much for your PR.
I'll have one of our developers review it to determine if any additional adjustments are needed or if it's ready to be merged.

@Buckaroo-Rene Buckaroo-Rene changed the title feat: add set articles to KlarnaKP pay function BA-639 Add set articles to KlarnaKP Pay function Nov 27, 2024
@Buckaroo-Rene Buckaroo-Rene added Feature Features that we are not providing yet. Priority: Normal This issue has a normal/medium priority. 👏Thank You✨ Thank you for contributing! Status: In progress We are working on this issue. labels Nov 27, 2024
Copy link
Contributor

@ShuCh3n ShuCh3n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment

@gijsmin gijsmin requested a review from ShuCh3n November 27, 2024 12:39
@ShuCh3n ShuCh3n merged commit 7919472 into buckaroo-it:master Nov 27, 2024
1 check failed
@Buckaroo-Rene Buckaroo-Rene added Status: Waiting for release This issue has been solved, but is not released yet. and removed Status: In progress We are working on this issue. labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Features that we are not providing yet. Priority: Normal This issue has a normal/medium priority. Status: Waiting for release This issue has been solved, but is not released yet. 👏Thank You✨ Thank you for contributing!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants