Auto cleanup option #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
dim
reviewed
Dec 21, 2022
| def initialize(options = nil) | ||
| @model = (options || {}).delete(:model) || Model | ||
| @auto_cleanup = (options || {}).delete(:auto_cleanup) || false |
There was a problem hiding this comment.
|| false will never yield a result, I would suggest (options || {}).delete(:auto_cleanup) == true instead
| @@ -20,8 +20,10 @@ def self.supports_cache_versioning? | |||
|
|
|||
| # param [Hash] options options | |||
| # option options [Class] :model model class. Default: ActiveSupport::Cache::DatabaseStore::Model | |||
| # option options [Boolean] :auto_cleanup When true, runs {#cleanup} after every {#write_entry} and {#delete_entry}. Default: false | |||
There was a problem hiding this comment.
Is there an example of any other store implementing this feature? I am not sure I agree with making this a boolean option and cleaning up on every write. I assume most users would want this to be a time-based option
|
So I revisited this PR and I am not sure it's necessary to clean up on every write. Instead it may be more beneficial to have a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an
auto_cleanupoption to theActiveSupport::Cache::DatabaseStoreclass initialization options.When true,
cleanupwill be run whenever awriteordeleteis executed. This keeps the amount of expired entries in the database small.