Fixed BingChat to recent API changes. #41

gunpal5 · 2023-10-06T23:23:03Z

Fixed BingChat to recent API changes. Now it is absolutely necessary to provide all of the Bing Cookies.
Added codes to ensure the conversation is authenticated.
Added retry mechanism on WebSocketException

this PR provides fixes to issues #40 #39 #38 #36

To use command line tool:

Copy Bing Cookies using Cookies Editor extension and save to a file.
Set BING_COOKIES_FILE environment variable by using this command
set [BING_COOKIES_FILE=[<path to cookies file>]]
dotnet bingchat

… to provide all the Bing Cookies. Added codes to ensure the conversation is authenticated. Added retry mechanism on WebSocketException

neon-sunset · 2023-10-07T16:15:41Z

Thank you for the pull request @gunpal5. However, it cannot be merged as is. There are a few points to address first:

Remove irrelevant comments
Use JsonSerializerContext instead of reflection-based serialization (<T>) (otherwise this will break AOT)
Double-check if the change to parse the cookie file is necessary - can we keep/describe all the necessary arguments via BingChatClientOptions type, where loading/parsing full cookie container remains an option for special use cases?
Fix syntax formatting errors
Remove transient build/IDE files

Used JsonSerializerContext instead of reflection-based serialization Removed transient IDE files

gunpal5 · 2023-10-07T19:42:57Z

@neon-sunset I made necessary changes you asked.

Regarding cookie files, I am not sure which cookie Bing is using to authenticate the chat. only passing _U and/or KievRPSSecAuth are not enough. someone else might figure out the right cookies to pass as arguments in BingChatClientOptions

I would advise to add a new argument CookieContainer in BIngChatClientOptions to pass the Bing Cookies, that would be more appropriate than to pass Cookies Editor file path.

gunpal5 · 2023-11-07T04:24:25Z

@neon-sunset It's been like a month, people need it. Please review and merge

neon-sunset · 2023-11-07T12:29:23Z

I understand that you would like to have this PR merged.
But I can't do it because it still has issues and does not approach the problem in a way this library is designed - it reverse engineers original BingChat logic and requires to configure only what's actually necessary. Forcing the users to dump all of the cookies being the only way for it to work is a workaround. My suggestion would be inspecting the API interaction flow closer and also checking out what the libraries in other languages do, and then porting their fixes to this PR.

neon-sunset · 2023-11-07T12:29:57Z

.vs/BingChat/FileContentIndex/fabd545b-3a9e-4b0f-9c70-8c16fd4a4260.vsidx

This file does not belong to the PR

neon-sunset · 2023-11-07T12:30:49Z

src/BingChat/BingChatClient.cs

@@ -107,11 +115,15 @@ public async Task<BingChatConversation> CreateConversation()
            throw new BingChatException(message);
        }

+        var encryptedConversationSignature = rawResponse.Headers.GetValues("X-Sydney-EncryptedConversationSignature").FirstOrDefault();


If this doesn't work without encryptedConversationSignature, shouldn't it be First() instead of FirstOrDefault()?

neon-sunset · 2023-11-07T12:31:22Z

src/BingChat/BingChatConversation.cs

    {
        _request = new BingChatRequest(clientId, conversationId, conversationSignature, tone);
+        _encryptedConversationSignature = encryptedConversationSignature;
+        this._cookies = cookies;


Suggested change

this._cookies = cookies;

_cookies = cookies;

neon-sunset · 2023-11-07T12:33:06Z

src/BingChat/BingChatConversation.cs

            HubProtocol,
-            HubEndpoint,
+            new UriEndPoint(new Uri(uri)),


You need to cache this property instead of creating it on each request.

neon-sunset · 2023-11-07T12:33:32Z

src/dotnet-bingchat/Utils.cs

        return new BingChatClient(new BingChatClientOptions
        {
            CookieU = string.IsNullOrWhiteSpace(cookie) ? null : cookie,
+            CookieFilePath = string.IsNullOrEmpty(cookieFile)? null: cookieFile,


Suggested change

CookieFilePath = string.IsNullOrEmpty(cookieFile)? null: cookieFile,

CookieFilePath = string.IsNullOrEmpty(cookieFile) ? null : cookieFile,

neon-sunset · 2023-11-07T12:34:10Z

src/dotnet-bingchat/dotnet-bingchat.csproj

Please revert all changes in this file.

neon-sunset · 2023-11-07T12:39:08Z

I'll need to give it another look over some time later with a proper IDE.

neon-sunset · 2023-11-07T12:41:18Z

src/BingChat/BingChatConversation.cs

+            }
+            catch (WebSocketException)
+            {
+                Thread.Sleep(100);


You must never use Thread.Sleep(...) in async methods or methods that can be called from async. The correct way to do it is to use Task.Delay(...) instead.

Gunpal Jain added 2 commits October 7, 2023 04:37

Fixed BingChat to recent APIs changes. Now it is absolutely necessary…

a1b9619

… to provide all the Bing Cookies. Added codes to ensure the conversation is authenticated. Added retry mechanism on WebSocketException

Removed launchSettings.

282c841

gunpal5 mentioned this pull request Oct 6, 2023

CLI The server returned status code '200' when status code '101' was expected. #38

Open

gunpal5 changed the title ~~Fixed BingChat to recent APIs changes.~~ Fixed BingChat to recent API changes. Oct 6, 2023

gunpal5 mentioned this pull request Oct 7, 2023

UnauthorizedRequest #40

Open

neon-sunset self-requested a review October 7, 2023 16:18

Removed irrelevant comments

048c84c

Used JsonSerializerContext instead of reflection-based serialization Removed transient IDE files

Fixed some syntax formatting errors

e536935

neon-sunset requested changes Nov 7, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixed BingChat to recent API changes. #41

Fixed BingChat to recent API changes. #41

gunpal5 commented Oct 6, 2023 •

edited

Loading

neon-sunset commented Oct 7, 2023 •

edited

Loading

gunpal5 commented Oct 7, 2023 •

edited

Loading

gunpal5 commented Nov 7, 2023

neon-sunset commented Nov 7, 2023

neon-sunset Nov 7, 2023

neon-sunset Nov 7, 2023 •

edited

Loading

neon-sunset Nov 7, 2023

neon-sunset Nov 7, 2023

neon-sunset Nov 7, 2023

neon-sunset Nov 7, 2023

neon-sunset commented Nov 7, 2023 •

edited

Loading

neon-sunset Nov 7, 2023 •

edited

Loading

	CookieFilePath = string.IsNullOrEmpty(cookieFile)? null: cookieFile,
	CookieFilePath = string.IsNullOrEmpty(cookieFile) ? null : cookieFile,

Fixed BingChat to recent API changes. #41

Are you sure you want to change the base?

Fixed BingChat to recent API changes. #41

Conversation

gunpal5 commented Oct 6, 2023 • edited Loading

neon-sunset commented Oct 7, 2023 • edited Loading

gunpal5 commented Oct 7, 2023 • edited Loading

gunpal5 commented Nov 7, 2023

neon-sunset commented Nov 7, 2023

neon-sunset Nov 7, 2023

Choose a reason for hiding this comment

neon-sunset Nov 7, 2023 • edited Loading

Choose a reason for hiding this comment

neon-sunset Nov 7, 2023

Choose a reason for hiding this comment

neon-sunset Nov 7, 2023

Choose a reason for hiding this comment

neon-sunset Nov 7, 2023

Choose a reason for hiding this comment

neon-sunset Nov 7, 2023

Choose a reason for hiding this comment

neon-sunset commented Nov 7, 2023 • edited Loading

neon-sunset Nov 7, 2023 • edited Loading

Choose a reason for hiding this comment

gunpal5 commented Oct 6, 2023 •

edited

Loading

neon-sunset commented Oct 7, 2023 •

edited

Loading

gunpal5 commented Oct 7, 2023 •

edited

Loading

neon-sunset Nov 7, 2023 •

edited

Loading

neon-sunset commented Nov 7, 2023 •

edited

Loading

neon-sunset Nov 7, 2023 •

edited

Loading