Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to scroll back and forth while playing a song #23

Open
kaelyavel opened this issue Apr 9, 2021 · 1 comment
Open

Ability to scroll back and forth while playing a song #23

kaelyavel opened this issue Apr 9, 2021 · 1 comment
Labels
feature New feature or request

Comments

@kaelyavel
Copy link

No description provided.

@kaelyavel kaelyavel changed the title Ability to scroll while playing a song Ability to scroll back and forth while playing a song Apr 9, 2021
@bryanbraun
Copy link
Owner

Yeah, so an early version of the site actually supported this feature, but I ended up moving away from it. At the time, I was using IntersectionObserver instead of WebAudio to play notes, but it ended up making the tempo less consistent, especially in Safari browsers. I have some notes in the code about it here.

But I think there's a couple options, while still keeping the consistency of Web Audio:

  1. Lock scrolling during play (what we currently do)
  2. If a song is playing and the user scrolls, immediately pause the song (kind of like we do when somebody changes the tempo mid-song).
  3. If a song is playing and the user scrolls, immediately pause the song, until the scrolling has stopped, after which we automatically start playing again from the new position.

I think we'd have to experiment with option 2 or 3 to see if it feels like a more natural experience than the current approach.

@bryanbraun bryanbraun added the feature New feature or request label Apr 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants