Clickhouse #397
Merged
Clickhouse #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Barbar1432
reviewed
Jan 13, 2025
|
|
||
| type ClickHouseClient interface { | ||
| RunQueryWithoutResult(ctx context.Context, query *query.Query) error | ||
| Select(ctx context.Context, query *query.Query) ([][]interface{}, error) |
There was a problem hiding this comment.
we can put SelectWithSchema and Ping here
albertobruin
force-pushed
the
feature/clickhouse
branch
from
1abedc0 to
5d8146c
Compare
Barbar1432
reviewed
Jan 17, 2025
| return err | ||
| } | ||
|
|
||
| for _, queryString := range materializedQueries { |
There was a problem hiding this comment.
In another operators we seem to be running only one query per task , will this be different in click house ?
There was a problem hiding this comment.
yes it will be. Some platforms allow you to send several statements in a single batch something like :
SELECT * from table;
INSERT ....;
DELETE ... FROM TABLE;As long as they are separated by a ;
Some others don't allow batches, you need to send statements one by one.
Other examples of this besides Clickhouse are Athena or Synapse
* Fix select methods to work with clickhouse * Fix tests
albertobruin
force-pushed
the
feature/clickhouse
branch
from
440122f to
4944449
Compare
albertobruin
force-pushed
the
feature/clickhouse
branch
from
56ca11e to
9214bda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.