Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smaller static #3

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Miha-x64
Copy link

@Miha-x64 Miha-x64 commented Mar 3, 2018

Consuming less memory:
— replaced char[64] Base64.CA and byte[64] Base64IO.CA with a single shared byte[64] (-128 bytes)
— replaced int[256] Base64.IA with byte[256] (-768 bytes);
— removed some int-to-byte narrowing casts, added byte-to-char expanding ones.
Speed test is running a bit faster on my machine — 12 seconds instead of 13.

@brsanthu
Copy link
Owner

brsanthu commented Apr 1, 2018

Hi, this is replica of code from other original source (but not treated as a fork). I would be hesitant to make this change here. Can you please propose this change in the original repo and then I can copy the change here?

@Miha-x64
Copy link
Author

Miha-x64 commented Apr 2, 2018

Hello.
Project at SourceForge does not look very alive.
Last release was in 2004, feature requests from 2007 and 2009 are still open.

@brsanthu
Copy link
Owner

brsanthu commented Apr 2, 2018

Thank you for your feedback. May be, will merge this and release as new version along with new test PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants