Add system path check to start command #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericbeland
reviewed
Sep 28, 2023
lib/commands/init.mjs
Outdated
| @@ -3,6 +3,19 @@ import fs from 'fs'; | |||
| import path from 'path'; | |||
| import ejs from 'ejs'; | |||
| import {getAbsolutePathFromRelativeToRoot} from "../utils/path_utils.mjs"; | |||
| import {isSystemDirectory} from "../commands/pathdetect.mjs"; | |||
There was a problem hiding this comment.
For filenames, we have a convention of separating words with underscores, so we probably want path_detect.mjs here.
lib/commands/init.mjs
Outdated
| import {isSystemDirectory} from "../commands/pathdetect.mjs"; | ||
| import { fileURLToPath } from 'url'; | ||
| import { dirname } from 'path'; | ||
| const __filename = fileURLToPath(import.meta.url); |
There was a problem hiding this comment.
I think the variables are private because we are in a module, so no need to underscore them in the names.
lib/commands/init.mjs
Outdated
| const __dirname = dirname(__filename); | ||
|
|
||
| let isSDirectory = isSystemDirectory(__dirname); | ||
| console.log(isSDirectory); |
There was a problem hiding this comment.
We probably don't want to keep this in the output, so we should clean that line up.
lib/commands/pathdetect.mjs
Outdated
| dirPath = dirPath.toLowerCase().replace(/\\+/g, '/'); | ||
| if (!dirPath.endsWith('/')) { | ||
| dirPath += '/'; | ||
| console.log(dirPath) |
There was a problem hiding this comment.
Is this meant to be just debug output, or were you thinking this should stay in our output?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a new file: lib/commands/pathdetect.mjs that contains a function to check if current working directory is a common system directory.
Edited lib/commands/init.mjs to print a warning to console if user is in current working dir, and exit with err code 1.