Error Type in callback #95
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yashLadha
force-pushed
the
chore/errorCallback_type
branch
from
51e0562
to
90025f9
Compare
yashLadha
force-pushed
the
chore/errorCallback_type
branch
from
90025f9
to
07aa1cb
Compare
elukoyanov
suggested changes
Jan 27, 2020
| @@ -19,9 +19,11 @@ declare module "browserstack-local" { | |||
| [key: string]: string | boolean; | |||
| } | |||
|
|
|||
| type LocalOptions = Partial<Options>; | |||
There was a problem hiding this comment.
Don't see any another use of LocalOptions.
Why it should be moved to declared type
There was a problem hiding this comment.
When other frameworks are integrating the options for passing as arguments, they need to have an interface to declare. This is why I have pulled out this.
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "browserstack-local", | |||
| "version": "1.4.5", | |||
| "version": "1.4.6", | |||
There was a problem hiding this comment.
Version bump for publishing in new package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.