Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move text about converting to skia.Rect earlier #1354

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Move text about converting to skia.Rect earlier #1354

merged 2 commits into from
Oct 25, 2024

Conversation

chrishtr
Copy link
Collaborator

@chrishtr chrishtr commented Oct 25, 2024 •
edited
Loading

That way we can use the skia.Rect API subsequently in DrawText, which was updated in #1352.

@chrishtr chrishtr requested a review from pavpanchekha October 25, 2024 03:51
@pavpanchekha pavpanchekha merged commit 72dfee1 into main Oct 25, 2024
1 check passed
@pavpanchekha pavpanchekha deleted the moverect branch October 25, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavpanchekha pavpanchekha pavpanchekha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrishtr @pavpanchekha