Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TBD] remove android/README.md with Maven publishing info - DRAFT WIP #333

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

[TBD] remove android/README.md with Maven publishing info - DRAFT WIP #333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4e7a69a
remove extra generated android/README.md
May 5, 2020
8964cd9
cleanup: remove extra `}, {` line from templates/android.js
May 5, 2020
d116d44
update test snapshots
May 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 0 additions & 18 deletions templates/android.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,22 +288,4 @@ public class ${name}Package implements ReactPackage {
}
}
`,
}, {
}, {
name: () => `${platform}/README.md`,
content: () => `README
======

If you want to publish the lib as a maven dependency, follow these steps before publishing a new version to npm:

1. Be sure to have the Android [SDK](https://developer.android.com/studio/index.html) and [NDK](https://developer.android.com/ndk/guides/index.html) installed
2. Be sure to have a \`local.properties\` file in this folder that points to the Android SDK and NDK
\`\`\`
ndk.dir=/Users/{username}/Library/Android/sdk/ndk-bundle
sdk.dir=/Users/{username}/Library/Android/sdk
\`\`\`
3. Delete the \`maven\` folder
4. Run \`./gradlew installArchives\`
5. Verify that latest set of generated files is in the maven folder with the correct version number
`
}];
18 changes: 0 additions & 18 deletions tests/integration/cli/create/view/__snapshots__/cli-create-with-view.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,24 +67,6 @@ import IntegrationViewTestPackage from 'react-native-integration-view-test-packa
// TODO: What to do with the module?
IntegrationViewTestPackage;
\`\`\`
",
},
Object {
"name": "react-native-integration-view-test-package/android/README.md",
"theContent": "README
======

If you want to publish the lib as a maven dependency, follow these steps before publishing a new version to npm:

1. Be sure to have the Android [SDK](https://developer.android.com/studio/index.html) and [NDK](https://developer.android.com/ndk/guides/index.html) installed
2. Be sure to have a \`local.properties\` file in this folder that points to the Android SDK and NDK
\`\`\`
ndk.dir=/Users/{username}/Library/Android/sdk/ndk-bundle
sdk.dir=/Users/{username}/Library/Android/sdk
\`\`\`
3. Delete the \`maven\` folder
4. Run \`./gradlew installArchives\`
5. Verify that latest set of generated files is in the maven folder with the correct version number
",
},
Object {
Expand Down
18 changes: 0 additions & 18 deletions .../integration/cli/create/with-defaults/__snapshots__/cli-create-with-defaults.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,24 +67,6 @@ import IntegrationTestPackage from 'react-native-integration-test-package';
// TODO: What to do with the module?
IntegrationTestPackage;
\`\`\`
",
},
Object {
"name": "react-native-integration-test-package/android/README.md",
"theContent": "README
======

If you want to publish the lib as a maven dependency, follow these steps before publishing a new version to npm:

1. Be sure to have the Android [SDK](https://developer.android.com/studio/index.html) and [NDK](https://developer.android.com/ndk/guides/index.html) installed
2. Be sure to have a \`local.properties\` file in this folder that points to the Android SDK and NDK
\`\`\`
ndk.dir=/Users/{username}/Library/Android/sdk/ndk-bundle
sdk.dir=/Users/{username}/Library/Android/sdk
\`\`\`
3. Delete the \`maven\` folder
4. Run \`./gradlew installArchives\`
5. Verify that latest set of generated files is in the maven folder with the correct version number
",
},
Object {
Expand Down
22 changes: 0 additions & 22 deletions ...-injection/create/view/with-defaults/__snapshots__/create-view-with-defaults.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@ Array [
"* ensureDir dir: react-native-alice-bobbi/android/src/main/java/com/reactlibrary/
",
"* ensureDir dir: react-native-alice-bobbi/android/src/main/java/com/reactlibrary/
",
"* ensureDir dir: react-native-alice-bobbi/android/
",
"* ensureDir dir: react-native-alice-bobbi/
",
Expand Down Expand Up @@ -384,26 +382,6 @@ public class AliceBobbiPackage implements ReactPackage {
}
}

<<<<<<<< ======== >>>>>>>>
",
"* outputFile name: react-native-alice-bobbi/android/README.md
content:
--------
README
======

If you want to publish the lib as a maven dependency, follow these steps before publishing a new version to npm:

1. Be sure to have the Android [SDK](https://developer.android.com/studio/index.html) and [NDK](https://developer.android.com/ndk/guides/index.html) installed
2. Be sure to have a \`local.properties\` file in this folder that points to the Android SDK and NDK
\`\`\`
ndk.dir=/Users/{username}/Library/Android/sdk/ndk-bundle
sdk.dir=/Users/{username}/Library/Android/sdk
\`\`\`
3. Delete the \`maven\` folder
4. Run \`./gradlew installArchives\`
5. Verify that latest set of generated files is in the maven folder with the correct version number

<<<<<<<< ======== >>>>>>>>
",
"* outputFile name: react-native-alice-bobbi/react-native-alice-bobbi.podspec
Expand Down
22 changes: 0 additions & 22 deletions ...h-example/with-defaults/__snapshots__/create-view-with-example-with-defaults.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,6 @@ Array [
"* ensureDir dir: react-native-alice-bobbi/android/src/main/java/com/reactlibrary/
",
"* ensureDir dir: react-native-alice-bobbi/android/src/main/java/com/reactlibrary/
",
"* ensureDir dir: react-native-alice-bobbi/android/
",
"* ensureDir dir: react-native-alice-bobbi/
",
Expand Down Expand Up @@ -388,26 +386,6 @@ public class AliceBobbiPackage implements ReactPackage {
}
}

<<<<<<<< ======== >>>>>>>>
",
"* outputFile name: react-native-alice-bobbi/android/README.md
content:
--------
README
======

If you want to publish the lib as a maven dependency, follow these steps before publishing a new version to npm:

1. Be sure to have the Android [SDK](https://developer.android.com/studio/index.html) and [NDK](https://developer.android.com/ndk/guides/index.html) installed
2. Be sure to have a \`local.properties\` file in this folder that points to the Android SDK and NDK
\`\`\`
ndk.dir=/Users/{username}/Library/Android/sdk/ndk-bundle
sdk.dir=/Users/{username}/Library/Android/sdk
\`\`\`
3. Delete the \`maven\` folder
4. Run \`./gradlew installArchives\`
5. Verify that latest set of generated files is in the maven folder with the correct version number

<<<<<<<< ======== >>>>>>>>
",
"* outputFile name: react-native-alice-bobbi/react-native-alice-bobbi.podspec
Expand Down
22 changes: 0 additions & 22 deletions ...ith-example/with-options/__snapshots__/create-view-with-example-with-options.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,6 @@ Array [
"* ensureDir dir: react-native-alice-bobbi/android/src/main/java/com/reactlibrary/
",
"* ensureDir dir: react-native-alice-bobbi/android/src/main/java/com/reactlibrary/
",
"* ensureDir dir: react-native-alice-bobbi/android/
",
"* ensureDir dir: react-native-alice-bobbi/
",
Expand Down Expand Up @@ -388,26 +386,6 @@ public class AliceBobbiPackage implements ReactPackage {
}
}

<<<<<<<< ======== >>>>>>>>
",
"* outputFile name: react-native-alice-bobbi/android/README.md
content:
--------
README
======

If you want to publish the lib as a maven dependency, follow these steps before publishing a new version to npm:

1. Be sure to have the Android [SDK](https://developer.android.com/studio/index.html) and [NDK](https://developer.android.com/ndk/guides/index.html) installed
2. Be sure to have a \`local.properties\` file in this folder that points to the Android SDK and NDK
\`\`\`
ndk.dir=/Users/{username}/Library/Android/sdk/ndk-bundle
sdk.dir=/Users/{username}/Library/Android/sdk
\`\`\`
3. Delete the \`maven\` folder
4. Run \`./gradlew installArchives\`
5. Verify that latest set of generated files is in the maven folder with the correct version number

<<<<<<<< ======== >>>>>>>>
",
"* outputFile name: react-native-alice-bobbi/react-native-alice-bobbi.podspec
Expand Down
22 changes: 0 additions & 22 deletions .../view/with-options/for-android/__snapshots__/lib-view-android-config-options.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@ Array [
"* ensureDir dir: react-native-alice-bobbi/android/src/main/java/com/reactlibrary/
",
"* ensureDir dir: react-native-alice-bobbi/android/src/main/java/com/reactlibrary/
",
"* ensureDir dir: react-native-alice-bobbi/android/
",
"* outputFile name: react-native-alice-bobbi/README.md
content:
Expand Down Expand Up @@ -352,26 +350,6 @@ public class AliceBobbiPackage implements ReactPackage {
}
}

<<<<<<<< ======== >>>>>>>>
",
"* outputFile name: react-native-alice-bobbi/android/README.md
content:
--------
README
======

If you want to publish the lib as a maven dependency, follow these steps before publishing a new version to npm:

1. Be sure to have the Android [SDK](https://developer.android.com/studio/index.html) and [NDK](https://developer.android.com/ndk/guides/index.html) installed
2. Be sure to have a \`local.properties\` file in this folder that points to the Android SDK and NDK
\`\`\`
ndk.dir=/Users/{username}/Library/Android/sdk/ndk-bundle
sdk.dir=/Users/{username}/Library/Android/sdk
\`\`\`
3. Delete the \`maven\` folder
4. Run \`./gradlew installArchives\`
5. Verify that latest set of generated files is in the maven folder with the correct version number

<<<<<<<< ======== >>>>>>>>
",
]
Expand Down
22 changes: 0 additions & 22 deletions tests/with-injection/create/with-defaults/__snapshots__/create-with-defaults.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@ Array [
"* ensureDir dir: react-native-alice-bobbi/android/src/main/java/com/reactlibrary/
",
"* ensureDir dir: react-native-alice-bobbi/android/src/main/java/com/reactlibrary/
",
"* ensureDir dir: react-native-alice-bobbi/android/
",
"* ensureDir dir: react-native-alice-bobbi/
",
Expand Down Expand Up @@ -385,26 +383,6 @@ public class AliceBobbiPackage implements ReactPackage {
}
}

<<<<<<<< ======== >>>>>>>>
",
"* outputFile name: react-native-alice-bobbi/android/README.md
content:
--------
README
======

If you want to publish the lib as a maven dependency, follow these steps before publishing a new version to npm:

1. Be sure to have the Android [SDK](https://developer.android.com/studio/index.html) and [NDK](https://developer.android.com/ndk/guides/index.html) installed
2. Be sure to have a \`local.properties\` file in this folder that points to the Android SDK and NDK
\`\`\`
ndk.dir=/Users/{username}/Library/Android/sdk/ndk-bundle
sdk.dir=/Users/{username}/Library/Android/sdk
\`\`\`
3. Delete the \`maven\` folder
4. Run \`./gradlew installArchives\`
5. Verify that latest set of generated files is in the maven folder with the correct version number

<<<<<<<< ======== >>>>>>>>
",
"* outputFile name: react-native-alice-bobbi/react-native-alice-bobbi.podspec
Expand Down
22 changes: 0 additions & 22 deletions ...-example/for-android-only/__snapshots__/create-with-example-for-android-only.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,6 @@ Array [
"* ensureDir dir: react-native-alice-bobbi/android/src/main/java/com/reactlibrary/
",
"* ensureDir dir: react-native-alice-bobbi/android/src/main/java/com/reactlibrary/
",
"* ensureDir dir: react-native-alice-bobbi/android/
",
"* outputFile name: react-native-alice-bobbi/README.md
content:
Expand Down Expand Up @@ -357,26 +355,6 @@ public class AliceBobbiPackage implements ReactPackage {
}
}

<<<<<<<< ======== >>>>>>>>
",
"* outputFile name: react-native-alice-bobbi/android/README.md
content:
--------
README
======

If you want to publish the lib as a maven dependency, follow these steps before publishing a new version to npm:

1. Be sure to have the Android [SDK](https://developer.android.com/studio/index.html) and [NDK](https://developer.android.com/ndk/guides/index.html) installed
2. Be sure to have a \`local.properties\` file in this folder that points to the Android SDK and NDK
\`\`\`
ndk.dir=/Users/{username}/Library/Android/sdk/ndk-bundle
sdk.dir=/Users/{username}/Library/Android/sdk
\`\`\`
3. Delete the \`maven\` folder
4. Run \`./gradlew installArchives\`
5. Verify that latest set of generated files is in the maven folder with the correct version number

<<<<<<<< ======== >>>>>>>>
",
"* execa.commandSync command: react-native init example --version react-native@latest options: {\\"cwd\\":\\"./react-native-alice-bobbi\\",\\"stdio\\":\\"inherit\\"}
Expand Down
22 changes: 0 additions & 22 deletions ...e/with-example/with-defaults/__snapshots__/create-with-example-with-defaults.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,6 @@ Array [
"* ensureDir dir: react-native-alice-bobbi/android/src/main/java/com/reactlibrary/
",
"* ensureDir dir: react-native-alice-bobbi/android/src/main/java/com/reactlibrary/
",
"* ensureDir dir: react-native-alice-bobbi/android/
",
"* ensureDir dir: react-native-alice-bobbi/
",
Expand Down Expand Up @@ -389,26 +387,6 @@ public class AliceBobbiPackage implements ReactPackage {
}
}

<<<<<<<< ======== >>>>>>>>
",
"* outputFile name: react-native-alice-bobbi/android/README.md
content:
--------
README
======

If you want to publish the lib as a maven dependency, follow these steps before publishing a new version to npm:

1. Be sure to have the Android [SDK](https://developer.android.com/studio/index.html) and [NDK](https://developer.android.com/ndk/guides/index.html) installed
2. Be sure to have a \`local.properties\` file in this folder that points to the Android SDK and NDK
\`\`\`
ndk.dir=/Users/{username}/Library/Android/sdk/ndk-bundle
sdk.dir=/Users/{username}/Library/Android/sdk
\`\`\`
3. Delete the \`maven\` folder
4. Run \`./gradlew installArchives\`
5. Verify that latest set of generated files is in the maven folder with the correct version number

<<<<<<<< ======== >>>>>>>>
",
"* outputFile name: react-native-alice-bobbi/react-native-alice-bobbi.podspec
Expand Down
22 changes: 0 additions & 22 deletions ...h-missing-package-scripts/__snapshots__/recover-from-missing-package-scripts.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,6 @@ Array [
"* ensureDir dir: react-native-alice-bobbi/android/src/main/java/com/reactlibrary/
",
"* ensureDir dir: react-native-alice-bobbi/android/src/main/java/com/reactlibrary/
",
"* ensureDir dir: react-native-alice-bobbi/android/
",
"* ensureDir dir: react-native-alice-bobbi/
",
Expand Down Expand Up @@ -389,26 +387,6 @@ public class AliceBobbiPackage implements ReactPackage {
}
}

<<<<<<<< ======== >>>>>>>>
",
"* outputFile name: react-native-alice-bobbi/android/README.md
content:
--------
README
======

If you want to publish the lib as a maven dependency, follow these steps before publishing a new version to npm:

1. Be sure to have the Android [SDK](https://developer.android.com/studio/index.html) and [NDK](https://developer.android.com/ndk/guides/index.html) installed
2. Be sure to have a \`local.properties\` file in this folder that points to the Android SDK and NDK
\`\`\`
ndk.dir=/Users/{username}/Library/Android/sdk/ndk-bundle
sdk.dir=/Users/{username}/Library/Android/sdk
\`\`\`
3. Delete the \`maven\` folder
4. Run \`./gradlew installArchives\`
5. Verify that latest set of generated files is in the maven folder with the correct version number

<<<<<<<< ======== >>>>>>>>
",
"* outputFile name: react-native-alice-bobbi/react-native-alice-bobbi.podspec
Expand Down
22 changes: 0 additions & 22 deletions ...-options/with-null-prefix/__snapshots__/create-with-example-with-null-prefix.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,6 @@ Array [
"* ensureDir dir: react-native-alice-bobbi/android/src/main/java/com/reactlibrary/
",
"* ensureDir dir: react-native-alice-bobbi/android/src/main/java/com/reactlibrary/
",
"* ensureDir dir: react-native-alice-bobbi/android/
",
"* ensureDir dir: react-native-alice-bobbi/
",
Expand Down Expand Up @@ -389,26 +387,6 @@ public class AliceBobbiPackage implements ReactPackage {
}
}

<<<<<<<< ======== >>>>>>>>
",
"* outputFile name: react-native-alice-bobbi/android/README.md
content:
--------
README
======

If you want to publish the lib as a maven dependency, follow these steps before publishing a new version to npm:

1. Be sure to have the Android [SDK](https://developer.android.com/studio/index.html) and [NDK](https://developer.android.com/ndk/guides/index.html) installed
2. Be sure to have a \`local.properties\` file in this folder that points to the Android SDK and NDK
\`\`\`
ndk.dir=/Users/{username}/Library/Android/sdk/ndk-bundle
sdk.dir=/Users/{username}/Library/Android/sdk
\`\`\`
3. Delete the \`maven\` folder
4. Run \`./gradlew installArchives\`
5. Verify that latest set of generated files is in the maven folder with the correct version number

<<<<<<<< ======== >>>>>>>>
",
"* outputFile name: react-native-alice-bobbi/react-native-alice-bobbi.podspec
Expand Down
Loading