Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ref_allele_mismatch in liftover_expr for indel variants #273

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Fix ref_allele_mismatch in liftover_expr for indel variants #273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8cbbb5a
fix liftover_expr
mkanai Nov 18, 2020
5f27570
add CHANGELOG
mkanai Nov 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
* Add reference genome to call of `has_liftover` in `get_liftover_genome` [(#259)](https://github.com/broadinstitute/gnomad_methods/pull/259)
* Added fix for MQ calculation in `_get_info_agg_expr`, switched `RAW_MQ` and `MQ_DP` in calculation [(#262)](https://github.com/broadinstitute/gnomad_methods/pull/262)
* Fix for error in `default_lift_data` caused by missing `results` field in `new_locus` [(#270)](https://github.com/broadinstitute/gnomad_methods/pull/270)
* Fix for incorrect `ref_allele_mismatch` error in `liftover_expr` when the original reference allele has more than one bp [(#273)](https://github.com/broadinstitute/gnomad_methods/pull/273)

## Version 0.4.0 - July 9th, 2020

Expand Down
4 changes: 3 additions & 1 deletion gnomad/utils/liftover.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,9 @@ def liftover_expr(
original_locus=locus,
original_alleles=alleles,
locus_fail_liftover=hl.is_missing(lifted_over_locus),
ref_allele_mismatch=lifted_over_locus.result.sequence_context()
ref_allele_mismatch=lifted_over_locus.result.sequence_context(
after=hl.len(alleles[0]) - 1
)
!= lifted_over_alleles[0],
)

Expand Down