Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lb update to 21 #198

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

lb update to 21 #198

wants to merge 1 commit into from

Conversation

lbergelson
Copy link
Member

  • Updating to java 21
  • update github actions to use java 21

@lbergelson
Copy link
Member Author

@cmnbroad Java 21 is very aggressive with "this-escape" warnings.

@lbergelson
Updating to java 21
21af155 
* replacing use of deprecated function
* making some methods final and Suppressing some 'this-escape' warnings
* update github actions to use java 21
@lbergelson lbergelson marked this pull request as ready for review December 18, 2023 21:59
@lbergelson
Copy link
Member Author

We probably don't want to merge this until we have similar branches for the whole pile of repos.

cmnbroad
cmnbroad approved these changes Dec 19, 2023
View reviewed changes
Copy link
Collaborator

@cmnbroad cmnbroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lbergelson !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmnbroad cmnbroad cmnbroad approved these changes

Assignees

@cmnbroad cmnbroad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lbergelson @cmnbroad