Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replacing the gradle java plugin with java-library #196

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Replacing the gradle java plugin with java-library #196

merged 1 commit into from
Dec 18, 2023

Conversation

lbergelson
Copy link
Member

  • updating vulnerable dependencies
  • replacing use of commons-lang Path with new barclay Path
  • reducing dependency scope where possible

@lbergelson
Replacing the gradle java plugin with java-library
237b02f 
* updating vulnerable dependencies
* replacing use of commons-lang Path with new barclay Path
* reducing dependency scope where possible
cmnbroad
cmnbroad reviewed Dec 18, 2023
View reviewed changes
Copy link
Collaborator

@cmnbroad cmnbroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine (we also use the old commons Pair class all over the place in GATK).

One request though - can you autogen/add hashCode /equals methods to Pair, since they get used all over the place.

@lbergelson
Copy link
Member Author

@cmnbroad One of the nice things about records is they do that for you. There are implicit equals/hashCode/toString methods that are reasonable and based on the declared fields.

https://docs.oracle.com/en/java/javase/17/language/records.html#GUID-6699E26F-4A9B-4393-A08B-1E47D4B2D263

@lbergelson
Copy link
Member Author

Getting rid of the commons pair in the interfaces is maybe a bit silly. Might as well try to reduce the dependency surface a bit though.

@lbergelson lbergelson merged commit f14e9a2 into master Dec 18, 2023
1 check passed
@lbergelson lbergelson deleted the lb_convert_to_java_library branch December 18, 2023 21:59
@cmnbroad
Copy link
Collaborator

Oh yeah - I knew that and completely forgot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmnbroad cmnbroad cmnbroad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lbergelson @cmnbroad