Bump tailwind to v4 stable + Build error will prevent a success build #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brisa-adapter-vercel
brisa-pandacss
brisa
brisa-tailwindcss
create-brisa
www
commit: |
aralroca
reviewed
Jan 24, 2025
AlbertSabate
force-pushed
the
tailwind-v4-stable
branch
from
2190fc7 to
2c1831a
Compare
|
Ready to review again! :) |
aralroca
reviewed
Jan 30, 2025
| @@ -2,126 +2,118 @@ import path from 'node:path'; | |||
| import type { Loader } from 'bun'; | |||
| import fs from 'node:fs'; | |||
| import { getConstants } from '@/constants'; | |||
| import { logError } from '../log/log-build'; | |||
There was a problem hiding this comment.
Why clear the logError with the try-catch? This is to give error feedback of the build in the terminal.
There was a problem hiding this comment.
Ok, it's fine because the error is handled upper
aralroca
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.