-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Features: gpt-4-vision, Configurable OpenAI Endpoint, Model, and System Prompt #8
Open
Josh-XT
wants to merge
46
commits into
brilliantlabsAR:main
Choose a base branch
from
Josh-XT:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some developers would prefer to develop something in Kotlin, others in Flutter, others in React Native... It is good to have as many examples of how to pair with one of these devices and use various back-ends, services, databases along with Brilliant Labs devices... Good to have that going regardless of the fate of this repo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Features
getResponse
function that used thecompletions
endpoint with thedivinci
model with a new function that uses the OpenAI chat completions endpoint. This enables the use of gpt-3.5-turbo, gpt-4, and gpt-4-vision.gpt-4-vision
support added when sending an image instead of doing the stable diffusion image to image.New first start up configuration (Resolves #7 )
https://api.openai.com/v1
so that no one has to look for it.) The purpose for this is to allow people to use third party OpenAI style endpoint services like ezlocalai as drop in replacements for OpenAI API.gpt-4-vision-preview
for the latest gpt-4 vision model.The assistant is Noa, the user's AR AI companion.
Clean up & Updates
getResponse
function that was inChatGptFragment
and referenced the new function withparentActivity.getResponse
.Recommendations post-merge
Other notes
I am a very experienced software engineer, but this is the first time I've ever touched Kotlin. I can't promise the highest quality here, but the added functionality not only makes the app usable again, it vastly improves its capabilities.
I was also informed in Discord that there is a Flutter app being built to replace the Kotlin one, but I was already well down this road and figured that it will make a good entrypoint for other developers to build off of this Noa app in Kotlin for their own applications. I wouldn't fully abandon this one, I would simply rename it
noa-for-android-kotlin
or something similar to serve as an example for developers to build on.There may be things I forgot to mention that I had to change along the way to make things work. My fork will continue to change and improve as I find better ways to do these things in Kotlin or ways to improve.