Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse Other Podcast Elements for Phase 1 & Phase 2 #59

Merged
merged 24 commits into from
Sep 27, 2023
Merged

Parse Other Podcast Elements for Phase 1 & Phase 2 #59

merged 24 commits into from
Sep 27, 2023

Conversation

devahmedshendy
Copy link
Contributor

@devahmedshendy devahmedshendy commented Sep 19, 2023 •
edited
Loading

#53
Implement elements of following "podcast" namespace phases:

@devahmedshendy devahmedshendy self-assigned this Sep 19, 2023
@codecov
Copy link

codecov bot commented Sep 19, 2023 •
edited
Loading

Codecov Report

Merging #59 (b913f81) into v0.3.8 (e136059) will increase coverage by 3.25%.
The diff coverage is 93.36%.

@@            Coverage Diff             @@
##           v0.3.8      #59      +/-   ##
==========================================
+ Coverage   81.12%   84.38%   +3.25%     
==========================================
  Files          41       51      +10     
  Lines         816     1018     +202     
==========================================
+ Hits          662      859     +197     
- Misses        154      159       +5
Flag Coverage Δ
13.3 84.38% <93.36%> (+3.25%) ⬆️
13.4.1 84.38% <93.36%> (+3.25%) ⬆️
14.0.1 84.38% <93.36%> (+3.25%) ⬆️
14.1 84.38% <93.36%> (+3.25%) ⬆️
14.2 84.38% <93.36%> (+3.25%) ⬆️
14.3.1 84.38% <93.36%> (+3.25%) ⬆️
15.0 84.38% <93.36%> (+3.25%) ⬆️
5.5.3 77.99% <80.91%> (+2.13%) ⬆️
5.6.3 84.38% <93.36%> (+3.25%) ⬆️
5.7.3 84.38% <93.36%> (+3.25%) ⬆️
5.8 84.38% <93.36%> (+3.25%) ⬆️
focal 84.38% <93.36%> (+3.25%) ⬆️
iOS 84.38% <93.36%> (+3.25%) ⬆️
iOS15.4 84.38% <93.36%> (+3.25%) ⬆️
iOS15.5 84.38% <93.36%> (+3.25%) ⬆️
iOS16.0 84.38% <93.36%> (+3.25%) ⬆️
iOS16.1 84.38% <93.36%> (+3.25%) ⬆️
iOS16.2 84.38% <93.36%> (+3.25%) ⬆️
iOS16.4 84.38% <93.36%> (+3.25%) ⬆️
iOS17.0 83.59% <93.36%> (+3.44%) ⬆️
jammy 84.38% <93.36%> (+3.25%) ⬆️
macOS 84.38% <93.36%> (+3.25%) ⬆️
spm 84.38% <93.36%> (+3.25%) ⬆️
watchOS 84.38% <93.36%> (+3.25%) ⬆️
watchOS10.0 83.59% <93.36%> (+3.44%) ⬆️
watchOS8.5 84.38% <93.36%> (+3.25%) ⬆️
watchOS9.0 84.38% <93.36%> (+3.25%) ⬆️
watchOS9.1 84.38% <93.36%> (+3.25%) ⬆️
watchOS9.4 84.38% <93.36%> (+3.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
Sources/SyndiKit/Character.swift 100.00% <100.00%> (ø)
Sources/SyndiKit/Collection.swift 100.00% <100.00%> (ø)
...ources/SyndiKit/Formats/Feeds/RSS/RSSChannel.swift 100.00% <ø> (ø)
Sources/SyndiKit/Formats/Feeds/RSS/RSSItem.swift 97.56% <100.00%> (+0.33%) ⬆️
...yndiKit/Formats/Media/Podcast/PodcastEpisode.swift 92.30% <100.00%> (ø)
...SyndiKit/Formats/Media/Podcast/PodcastLocked.swift 100.00% <100.00%> (ø)
...SyndiKit/Formats/Media/Podcast/PodcastPerson.swift 100.00% <100.00%> (ø)
.../SyndiKit/Formats/Media/Wordpress/WPCategory.swift 100.00% <100.00%> (ø)
.../SyndiKit/Formats/Media/Wordpress/WPPostMeta.swift 100.00% <100.00%> (ø)
...urces/SyndiKit/Formats/Media/Wordpress/WPTag.swift 100.00% <100.00%> (ø)
... and 9 more

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

leogdion
leogdion reviewed Sep 21, 2023
View reviewed changes
Copy link
Member

@leogdion leogdion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove all value properties as well

Sources/SyndiKit/Formats/Media/Podcast/PodcastChapters.swift Outdated Show resolved Hide resolved
Sources/SyndiKit/Formats/Media/Podcast/PodcastFunding.swift Outdated Show resolved Hide resolved
Sources/SyndiKit/Formats/Media/Podcast/PodcastLocked.swift Outdated Show resolved Hide resolved
Sources/SyndiKit/Formats/Media/Podcast/PodcastSeason.swift Outdated Show resolved Hide resolved
Sources/SyndiKit/Formats/Media/Podcast/PodcastTranscript.swift Outdated Show resolved Hide resolved
Sources/SyndiKit/Formats/Media/Podcast/PodcastTranscript.swift Outdated Show resolved Hide resolved
@devahmedshendy devahmedshendy changed the title Parse Other Podcast Elements Parse Other Podcast Elements for Phase 1 & Phase 2 Sep 22, 2023
leogdion
leogdion reviewed Sep 22, 2023
View reviewed changes
Copy link
Member

@leogdion leogdion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make all arrays non-optional

Sources/SyndiKit/Formats/Feeds/RSS/RSSChannel.swift Outdated Show resolved Hide resolved
Sources/SyndiKit/Formats/Feeds/RSS/RSSItem.swift Outdated Show resolved Hide resolved
Sources/SyndiKit/Formats/Feeds/RSS/RSSItem.swift Outdated Show resolved Hide resolved
Sources/SyndiKit/Formats/Media/Podcast/PodcastLocked.swift Outdated Show resolved Hide resolved
Sources/SyndiKit/Formats/Media/Podcast/PodcastLocked.swift Outdated Show resolved Hide resolved
Sources/SyndiKit/Formats/Media/Podcast/PodcastTranscript.swift Outdated Show resolved Hide resolved
Sources/SyndiKit/Formats/Media/Podcast/PodcastTranscript.swift Outdated Show resolved Hide resolved
Sources/SyndiKit/Formats/Media/Podcast/PodcastTranscript.swift Outdated Show resolved Hide resolved
@devahmedshendy devahmedshendy marked this pull request as ready for review September 22, 2023 21:15
leogdion
leogdion reviewed Sep 26, 2023
View reviewed changes
Copy link
Member

@leogdion leogdion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the xml comments on top.

Sources/SyndiKit/Formats/Media/Podcast/PodcastLocation.swift Outdated Show resolved Hide resolved
Sources/SyndiKit/Formats/Media/Podcast/PodcastTranscript+MimeType.swift Outdated Show resolved Hide resolved
leogdion
leogdion requested changes Sep 27, 2023
View reviewed changes
Copy link
Member

@leogdion leogdion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove all xml comments

Sources/SyndiKit/Formats/Media/Podcast/PodcastLocation.swift Outdated Show resolved Hide resolved
Sources/SyndiKit/Formats/Media/Podcast/PodcastLocation+GeoURI.swift Show resolved Hide resolved
Sources/SyndiKit/Formats/Media/Podcast/PodcastLocation+OsmQuery.swift Outdated Show resolved Hide resolved
Sources/SyndiKit/Formats/Media/Podcast/PodcastLocation+GeoURI.swift Show resolved Hide resolved
Sources/SyndiKit/Formats/Media/Podcast/PodcastLocation.swift Outdated Show resolved Hide resolved
Sources/SyndiKit/Formats/Media/Podcast/PodcastPerson.swift Outdated Show resolved Hide resolved
@leogdion leogdion merged commit 0b7b3c1 into v0.3.8 Sep 27, 2023
16 checks passed
@leogdion leogdion deleted the parse-podcast-elements branch September 27, 2023 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leogdion leogdion Awaiting requested review from leogdion

Assignees

@devahmedshendy devahmedshendy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devahmedshendy @leogdion