Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solve: issue #51 - equatable wordpress elements and open their proper… #52

Merged
merged 2 commits into from
Aug 27, 2023

Conversation

leogdion
Copy link
Member

…ties to public

@codecov
Copy link

codecov bot commented Aug 26, 2023

Codecov Report

Merging #52 (f557c5f) into v0.3.5 (a039578) will increase coverage by 0.30%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           v0.3.5      #52      +/-   ##
==========================================
+ Coverage   80.46%   80.76%   +0.30%     
==========================================
  Files          37       39       +2     
  Lines         768      780      +12     
==========================================
+ Hits          618      630      +12     
  Misses        150      150              
Flag Coverage Δ
5.5.3 75.03% <60.00%> (-0.41%) ⬇️
5.6.3 80.64% <100.00%> (+0.31%) ⬆️
5.7.3 80.64% <100.00%> (+0.31%) ⬆️
5.8 80.64% <100.00%> (+0.31%) ⬆️
focal 80.64% <100.00%> (+0.31%) ⬆️
github 80.64% <100.00%> (+0.31%) ⬆️
iOS 80.76% <100.00%> (+0.30%) ⬆️
iOS-15.4 80.76% <100.00%> (+0.30%) ⬆️
iOS-15.5 80.76% <100.00%> (+0.30%) ⬆️
iOS-16.0 80.76% <100.00%> (+0.30%) ⬆️
iOS-16.1 80.76% <100.00%> (+0.30%) ⬆️
iOS-16.2 80.76% <100.00%> (+0.30%) ⬆️
iOS-16.4 80.76% <100.00%> (+0.30%) ⬆️
jammy 80.64% <100.00%> (+0.31%) ⬆️
spm 80.76% <100.00%> (+0.30%) ⬆️
watchOS 80.76% <100.00%> (+0.30%) ⬆️
watchOS8.5 80.76% <100.00%> (+0.30%) ⬆️
watchOS9.0 80.76% <100.00%> (+0.30%) ⬆️
watchOS9.1 80.76% <100.00%> (+0.30%) ⬆️
watchOS9.4 80.76% <100.00%> (+0.30%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
Sources/SyndiKit/Common/Primitives/CData.swift 84.61% <ø> (ø)
.../SyndiKit/Formats/Media/Wordpress/WPCategory.swift 100.00% <100.00%> (ø)
.../SyndiKit/Formats/Media/Wordpress/WPPostMeta.swift 100.00% <100.00%> (ø)
...urces/SyndiKit/Formats/Media/Wordpress/WPTag.swift 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@leogdion
Copy link
Member Author

Codecov Report

Merging #52 (48ab3a7) into v0.3.5 (a039578) will decrease coverage by 1.24%.
The diff coverage is 20.00%.

@@            Coverage Diff             @@
##           v0.3.5      #52      +/-   ##
==========================================
- Coverage   80.46%   79.23%   -1.24%     
==========================================
  Files          37       39       +2     
  Lines         768      780      +12     
==========================================
  Hits          618      618              
- Misses        150      162      +12     

Flag Coverage Δ
5.5.3 74.23% <20.00%> (-1.21%) ⬇️
5.6.3 79.03% <20.00%> (-1.29%) ⬇️
5.7.3 79.03% <20.00%> (-1.29%) ⬇️
5.8 79.03% <20.00%> (-1.29%) ⬇️
focal 79.03% <20.00%> (-1.29%) ⬇️
github 79.03% <20.00%> (-1.29%) ⬇️
iOS 79.23% <20.00%> (-1.24%) ⬇️
iOS-15.4 79.23% <20.00%> (-1.24%) ⬇️
iOS-15.5 79.23% <20.00%> (-1.24%) ⬇️
iOS-16.0 79.23% <20.00%> (-1.24%) ⬇️
iOS-16.1 79.23% <20.00%> (-1.24%) ⬇️
iOS-16.2 79.23% <20.00%> (-1.24%) ⬇️
iOS-16.4 79.23% <20.00%> (-1.24%) ⬇️
jammy 79.03% <20.00%> (-1.29%) ⬇️
spm 79.23% <20.00%> (-1.24%) ⬇️
watchOS 79.23% <20.00%> (-1.24%) ⬇️
watchOS8.5 79.23% <20.00%> (-1.24%) ⬇️
watchOS9.0 79.23% <20.00%> (-1.24%) ⬇️
watchOS9.1 79.23% <20.00%> (-1.24%) ⬇️
watchOS9.4 79.23% <20.00%> (-1.24%) ⬇️
Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
Sources/SyndiKit/Common/Primitives/CData.swift 84.61% <ø> (ø)
.../SyndiKit/Formats/Media/Wordpress/WPCategory.swift 0.00% <0.00%> (ø)
...urces/SyndiKit/Formats/Media/Wordpress/WPTag.swift 0.00% <0.00%> (ø)
.../SyndiKit/Formats/Media/Wordpress/WPPostMeta.swift 50.00% <50.00%> (-50.00%) ⬇️
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@devahmedshendy can fix the unit tests for this

@devahmedshendy devahmedshendy self-assigned this Aug 27, 2023
@devahmedshendy devahmedshendy marked this pull request as ready for review August 27, 2023 04:38
@leogdion
Copy link
Member Author

Fixes Issue #51

@leogdion leogdion merged commit 0ef1dba into v0.3.5 Aug 27, 2023
16 checks passed
@leogdion leogdion deleted the v0.3.5-issue51 branch August 27, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants