-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test enhancement #1
Open
peter279k
wants to merge
9
commits into
brick:master
Choose a base branch
from
peter279k:test_enhancement
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
1bde7a1
enhance ReflectionTool test
peter279k 506bdf8
complete ImportResolver test
peter279k c206ca6
set the correct autoload-dev files
peter279k 14625aa
add EOF for composer.json
peter279k 978255d
approve request changes, merge the two functions
peter279k 6583e51
fix the assertions and test method name
peter279k acbbd21
Merge https://github.com/brick/reflection
peter279k 91cab56
fix the typo doc block
peter279k 5a11f9a
fix the assertions value
peter279k File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
<?php | ||
|
||
namespace Brick\Reflection\Tests; | ||
|
||
/** | ||
* The Reflection Target class. | ||
*/ | ||
class ReflectionTarget | ||
{ | ||
/** | ||
* @param string | ||
*/ | ||
private $foo; | ||
|
||
/** | ||
* @var string $bar | ||
*/ | ||
private $bar; | ||
|
||
/** | ||
* @var \Exception $barWithType | ||
*/ | ||
private $barWithType; | ||
|
||
public function __construct() | ||
{ | ||
$this->foo = 'foo'; | ||
$this->bar = 'bar'; | ||
} | ||
|
||
/** | ||
* @param string $str | ||
*/ | ||
private function privateFunc(string $str) | ||
{ | ||
return $str; | ||
} | ||
|
||
/** | ||
* @return void | ||
*/ | ||
public static function publicStaticMethod() {} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
<?php | ||
|
||
namespace Brick\Reflection\Tests; | ||
|
||
/** | ||
* The Target Reflection function without parameter. | ||
*/ | ||
function reflectedFunc() | ||
{ | ||
return 'test'; | ||
} | ||
|
||
/** | ||
* The Target Reflection function with string parameter. | ||
* @param string $arg | ||
*/ | ||
function reflectedParameterFunc(string $arg) | ||
{ | ||
return isset($arg) ? $arg : 'test'; | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be
@var string
, without variable name