ECS+Rector+CI/CD rules #71
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, we're in the process of standardizing the ci checks for every brick organization projects with @BenMorel You can check brick/date-time#62 I won't get back to it until end of this month but if you want to team up with me and push forward those topics feel free. I'll be happy to help. |
|
Excellent! That's a good one I missed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THis PR adds ECS (see #44) and Rector to ease mainting coding standards and allowing to upgrade to newer PHP version in a smooth way.
In addition, two workflows are added to help detecting new PRs where modifications could be improved.
Note that the proposed rules are highly opiniated.
If you disagree with one or the other, I will be happy to revert it.