Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added examples folder && update README.md #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

KameeKaze
Copy link

I created _examples folder to contain all example files. Also updated README.md with an install, and updated all examples.

@brianvoe
Copy link
Owner

Oh I am so sorry I missed this!!! Not sure why github didnt send me an email about it.

I like the readme updates. For the examples instead of a subfolder I like to create ExampleFunctionName and do outputs for the values. That way when docs are generated you can have your actual examples show in usages and they will be treated as tests as well.

I run Gofakeit as well and here is an link of how I do examples for it. https://github.com/brianvoe/gofakeit/blob/master/auth_test.go#L60

If you want to update it to use examples like this ill get this pr merged in ASAP!

Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants