Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipelining #3357

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Pipelining #3357

wants to merge 4 commits into from

Conversation

mcollina
Copy link

@mcollina mcollina commented Jan 14, 2025

This is a reopen of #2706, hopefully completing it soon.

@cesco69
Copy link
Contributor

cesco69 commented Jan 15, 2025

Just for remind, the pipeline mode should also be implemented in the pg-native client:
https://github.com/brianc/node-postgres/blob/master/packages/pg-native/index.js#L9

Thanks so much!

@mcollina mcollina marked this pull request as draft January 15, 2025 11:14
@brianc
Copy link
Owner

brianc commented Jan 17, 2025

Just for remind, the pipeline mode should also be implemented in the pg-native client:

Also, I'm fine accepting additions in just JavaScript which can be ported to the native module at a later date if you're not comfortable working on it. Particularly if it requires c/c++ binding changes. There are several "pure javascript only" features already such as pg-cursor and pg-query-stream only supporting the pure JS client.

pls lmk how I can help out here!

@mcollina
Copy link
Author

@brianc can you approve the workflow run so we know where things are in CI?

@brianc
Copy link
Owner

brianc commented Jan 23, 2025

It doesnt give me the option while its a draft. Lemme mark it as ready and try.

Edit: nevermind. It did. Was behind a dropdown. Anyways, running now!

@brianc brianc marked this pull request as ready for review January 23, 2025 16:54
@brianc
Copy link
Owner

brianc commented Jan 23, 2025

I changed the rules on the CI runner to be more lax & auto-run in more situations. I might still have to approve some, but shouldn't require me to approve it quite as much which is good. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants