Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align BrefKernel::handle method signature with the Symfony\Component\HttpKernel\HttpKernelInterface #68

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

smoench
Copy link
Contributor

@smoench smoench commented Feb 19, 2024

This package has a minimum requirement for Symfony 5.4 and therefore we can align the method signature with the interface. This is no BC-break as PHP allows to remove type declaration on method overrides.

@mnapoli
Copy link
Member

mnapoli commented Feb 20, 2024

Thanks!

@mnapoli mnapoli merged commit 1bab91b into brefphp:master Feb 20, 2024
7 checks passed
@smoench smoench deleted the patch-2 branch February 20, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants