Concurrent execution #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @mnapoli, wondering whether you've had a chance to look over this PR? Let me know your thoughts... Thanks, Scott |
…ref due to additional header data logged from stdout logging in the application. This strips everything before "END Duration" which guarantees no further output from code other than Bref.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for concurrent execution of Bref.
This addresses #15, but uses a different approach that discussed in that ticket.
This PR uses
docker execto run thebref-localCLI tool directly within the Bref PHP container, where it can run multiple processes concurrently.I've found the Docker approach is more robust than using Lambda RIE (and I was pushed to write it because Lambda RIE began crashing for me). It's also much, much faster. It does however move away from the AWS RIE tool and some folks may still want to use that, so i've left that code in place as a BC option for others.
I haven't worked on test automation as I'm not quite sure how's best to do this, plus I'm currently having troubles even getting this project's tests working on my machine (I think something's going on with node since an update in early 2025). Anyway, I'm happy to help work on this but I figure a collaboration with you is best if you want to incorporate this fork, plus I'm blocked right now in doing so.
I've put together a video to talk through the code and show a demo of it running:
https://www.loom.com/share/a906c414a33c418993c34fe1a0d7ec1c