Handle 'common' web file MIME types #168
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This handles serving 'common' (js, css, html) file types within the static assets middleware. The returned MIME type for these files is `text/plain` and based on this we attempt to determine the correct MIME type via their file extension. This is by no means an exhaustive list but provides support for files which would be typical for a web application.
eddmann
commented
Jan 16, 2025
| @@ -43,12 +43,20 @@ public function handle(Request $request, Closure $next) | |||
| protected function getMimeType(string $file) | |||
| { | |||
| $mimeType = finfo_file(finfo_open(FILEINFO_MIME_TYPE), $file); | |||
| $mimeType = strstr($mimeType, ';', true); | |||
There was a problem hiding this comment.
Work on this initially arose due to an issue with this line, the returned MIME type does not look to include a ; and as such returns false. This results in the MIME type always being empty and the 'Content-Type' subsequently being empty in the response.
If the need for this change is not deemed nessary, I would be happy to put together another MR which fixes this issue. We could either:
- Remove the line, as upon testing I did not noticed any
;(i.e. including the charset) in the MIME type response - Appending a
;to the MIME type output so it will always be found and the correct part of the MIME type is returned.
mnapoli
approved these changes
Jan 16, 2025
georgeboot
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This handles serving 'common' (js, css, html) file types within the static assets middleware. The returned MIME type for these files is
text/plainand based on this we attempt to determine the correct MIME type via their file extension.This is by no means an exhaustive list but provides support for files which would be typical for a web application.