Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests around connectivity issues #74

Merged
merged 6 commits into from
Apr 9, 2024

Conversation

matehat
Copy link
Member

@matehat matehat commented Apr 9, 2024

Test that the following scenarios work:

  1. Connection starts dead, socket connect is initiated, connection is restored, socket connect succeeds
  2. Connection starts as usual, socket connection is established, connection drops, channel join is attempted, connection is restored, channel join succeeds
  3. Connection starts as usual, socket connection is established and channel joined, connection drops then is restored, message is sent on channel and reply is received

To test those, a control side-channel was added to the test backend so the client can tell the backend to start and stop the websocket server at precise times.

@matehat matehat requested review from Pacane and phildupuis April 9, 2024 02:36
@matehat matehat merged commit fb11446 into master Apr 9, 2024
2 checks passed
@matehat matehat deleted the mathieu/add-connectivity-tests branch April 9, 2024 18:16
s6o pushed a commit to s6o/phoenix-socket-dart that referenced this pull request May 23, 2024
* add tests around connectivity issues

* ensure backend always is always started

* expose control side-channel

* add build container workflow

* tag image as latest

* properly set tags
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant