Refactor: Reduce reliance of the package on 3rd party dependencies #72
+107
−79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndelanou
suggested changes
Apr 2, 2024
collection was only used for |
ndelanou
suggested changes
Apr 2, 2024
matehat
requested changes
Apr 8, 2024
matehat
approved these changes
Apr 9, 2024
s6o
pushed a commit
to s6o/phoenix-socket-dart
that referenced
this pull request
May 23, 2024
…raverhealth#72) * refactor: remove dependency to pedantic * refactor: removed equatable * refactor: enforce typing of MessageSerializer callbacks * refactor: removed dependency to meta * chore: bump dev_dependencies * refactor: removed dependency to collection * refactor: removed dependency to quiver * refactor: made PhoenixSocketEvent const * refactor: set empty list for receivers * refactor: one line addition to list * refactor: one line clear * refactor: feedbacks * refactor: feedbacks * refactor: expression bodies * refactor: 1 line receivers assignation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm seeing that this package has a lot of 3rd party dependencies that could be avoided. This is not good as some might conflict in projects that also depend on it (and it might also make the maintenance more cumbersome).
This PR aims to reduce the number of dependencies to its bare minimum.
Removed dependencies
collection-> implementedfirstWhereOrNulllocallyequatable-> override equality operator and hashCode for the classes that needed itmeta-> RefactoredPhoenixSocketOptionsso it can be madeconstpedantic-> Not needed and deprecatedquiver-> ReplacedListMultimap<String, void Function(PushResponse)>with aMap<String, List<void Function(PushResponse)>>I've also bumped the version of the dev dependencies and bumped the minimum version of the Dart SDK to
3.0.0so pattern matching can be used.