-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ads] Profile performance using TRACE events #27181
base: master
Are you sure you want to change the base?
Conversation
5ae4e5d
to
4987e7f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
chromium_src
++
[puLL-Merge] - brave/brave-core@27181 Here's a description and analysis of the pull request: DescriptionThis PR adds tracing and performance monitoring capabilities to the Brave Ads component. It introduces trace events at various points in the ad serving pipeline, allowing for better performance analysis and debugging. The changes primarily involve adding trace events, restructuring some callback flows, and improving error handling. ChangesChanges
sequenceDiagram
participant User
participant BraveAds
participant Database
participant AdServing
participant Targeting
participant UserEngagement
User->>BraveAds: Interact with browser
BraveAds->>Database: RunDBTransaction
Note over Database: TRACE_EVENT: Database operations
Database-->>BraveAds: Transaction result
BraveAds->>AdServing: Serve ad
Note over AdServing: TRACE_EVENT: Ad serving pipeline
AdServing->>Targeting: Get user model
Note over Targeting: TRACE_EVENT: Text classification
Targeting-->>AdServing: User model
AdServing->>UserEngagement: Check for conversions
Note over UserEngagement: TRACE_EVENT: Conversion checking
UserEngagement-->>AdServing: Conversion result
AdServing-->>BraveAds: Served ad
BraveAds->>User: Display ad
Possible Issues
Security HotspotsNo significant security issues are apparent in this change. The tracing additions don't expose sensitive information and are primarily for debugging and performance analysis. This sequence diagram illustrates the high-level flow of the Brave Ads system with the newly added trace events, showing how various components interact and where tracing has been added for performance monitoring. |
8589703
to
a81e13d
Compare
Resolves brave/brave-browser#21106
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: