Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add googleadservices.com (fixes #865) #912

Merged
merged 1 commit into from
Jul 6, 2022
Merged

Conversation

fmarier
Copy link
Member

@fmarier fmarier commented Jul 4, 2022

Resolves #865.

This reintroduces a rule that was removed in #805 as a work-around for a webcompat problem that was actually caused by different rules. Details on the above issue.

Sample URL: https://www.googleadservices.com/pagead/aclk?sa=L&ai=CpwMy_pA7YueBHMWV9AOwxrvgBPXF1eJm38Xi3KwMvLjk5vMNCAQQASgLYMmO8IbIo6AZoAGJg8X-A8gBB8gD2CCqBFxP0BVaXHBw0bTsk4SdtAz6eTEkpO5bWMb0JJ9zZZjWgQ4Tv1T4gTUaNmPp2H5322pGRBg-y3P7jmsjL3XDZO_AP6DTNRPxMNYb_zx-BXL8fbGHuo08uK48cCAPJcAEvoPWoo8DiAW0qZjfKcAFBaAGJoAH3_y6AYgHAZAHAagHpr4bqAe5mrECqAfz0RuoB-7SG6gH_5yxAqgHytwbqAfNo7ECoAjA8j2wCAHACAHSCAwQAiCEATICgkA6AQCaCVJodHRwczovL3d3dy5zd2VldHdhdGVyLmNvbS9zdG9yZS9kZXRhaWwvRDQ1WTgtLW1hcnRpbi1kLTQ1LWFjb3VzdGljLWd1aXRhci1uYXR1cmFssQmJ4KBqN-lXPbkJXM7iZAP2Jnn4CQHQCyrgCwGqDAIIAbgMAegMBuAS5vSK6fz787uAAYIUBAgBEgDQFQHpFY-4wNPDibHa8BWodvoVBUQ0NVk4gRa7V5yQTETaeYgWUJgWAbgWwPm8sSPAFsD5vLEj6hYECKzqIPgWAYAXAZIXCRIHCAEQAxjBAg&ctype=5&ved=2ahUKEwjawK7Jlt32AhX8Mn0KHaQUC5wQww96BAgBED0&cid=CAASFeRo9mEa81pQI8r5S7W87ZZ_MHUHVQ&dblrd=1&sival=AF15MEBme8-y7XM2ojdjUz9fPC5ilL9_jZ_4bwjLYo_PY-5CKrjcK2pH8B8y4aUUpseGeC5QdxGD4HpvRTSoslTwUXuVGrOPyUT5FHwykqwCMJv-7fHk3NWTk_ArH_nz0bfn1pJtHAWHFJAw8820rzgIbB48F3ZbiaBTfESZY29iIzi1ngqq6mDaMpINh3X7MuQq3L90K_rr&sig=AOD64_2IpBc4vty-6Tc066z47dc0zFEJ0g&adurl=https://clickserve.dartsearch.net/link/click%3Flid%3D92700057522574369%26ds_s_kwgid%3D58700006368161508%26ds_s_inventory_feed_id%3D97700000007215323%26ds_a_cid%3D2001181%26ds_a_caid%3D11205481652%26ds_a_agid%3D107178459582%26ds_a_fiid%3D%26ds_a_lid%3Dpla-477762231356%26ds_a_extid%3D%26%26ds_e_adid%3D470980643466%26ds_e_matchtype%3Dsearch%26ds_e_device%3Dc%26ds_e_network%3Dg%26ds_e_product_group_id%3D477762231356%26ds_e_product_id%3DD45Y8%26ds_e_product_merchant_id%3D15144%26ds_e_product_country%3DUS%26ds_e_product_language%3Den%26ds_e_product_channel%3Donline%26ds_e_product_store_id%3D%26ds_url_v%3D2%26ds_dest_url%3Dhttps://www.sweetwater.com/store/detail/D45Y8--martin-d-45-acoustic-guitar-natural%3Futm_source%3Dgoogle%26utm_medium%3Dorganicpla%26mrkgadid%3D%26mrkgcl%3D28%26mrkgen%3Dgpla%26mrkgbflag%3D0%26mrkgcat%3D%26acctid%3D21700000001645388%26dskeywordid%3D92700057522574369%26lid%3D92700057522574369%26ds_s_kwgid%3D58700006368161508%26ds_s_inventory_feed_id%3D97700000007215323%26dsproductgroupid%3D477762231356%26product_id%3DD45Y8%26prodctry%3DUS%26prodlang%3Den%26channel%3Donline%26storeid%3D%26device%3Dc%26network%3Dg%26matchtype%3D%26adpos%3Dlargenumber%26locationid%3D1014080%26creative%3D470980643466%26targetid%3Dpla-477762231356%26campaignid%3D11205481652%26awsearchcpc%3D1%26gclsrc%3Daw.ds%26

Sample URL: https://www.googleadservices.com/pagead/aclk?sa=L&ai=CpwMy_pA7YueBHMWV9AOwxrvgBPXF1eJm38Xi3KwMvLjk5vMNCAQQASgLYMmO8IbIo6AZoAGJg8X-A8gBB8gD2CCqBFxP0BVaXHBw0bTsk4SdtAz6eTEkpO5bWMb0JJ9zZZjWgQ4Tv1T4gTUaNmPp2H5322pGRBg-y3P7jmsjL3XDZO_AP6DTNRPxMNYb_zx-BXL8fbGHuo08uK48cCAPJcAEvoPWoo8DiAW0qZjfKcAFBaAGJoAH3_y6AYgHAZAHAagHpr4bqAe5mrECqAfz0RuoB-7SG6gH_5yxAqgHytwbqAfNo7ECoAjA8j2wCAHACAHSCAwQAiCEATICgkA6AQCaCVJodHRwczovL3d3dy5zd2VldHdhdGVyLmNvbS9zdG9yZS9kZXRhaWwvRDQ1WTgtLW1hcnRpbi1kLTQ1LWFjb3VzdGljLWd1aXRhci1uYXR1cmFssQmJ4KBqN-lXPbkJXM7iZAP2Jnn4CQHQCyrgCwGqDAIIAbgMAegMBuAS5vSK6fz787uAAYIUBAgBEgDQFQHpFY-4wNPDibHa8BWodvoVBUQ0NVk4gRa7V5yQTETaeYgWUJgWAbgWwPm8sSPAFsD5vLEj6hYECKzqIPgWAYAXAZIXCRIHCAEQAxjBAg&ctype=5&ved=2ahUKEwjawK7Jlt32AhX8Mn0KHaQUC5wQww96BAgBED0&cid=CAASFeRo9mEa81pQI8r5S7W87ZZ_MHUHVQ&dblrd=1&sival=AF15MEBme8-y7XM2ojdjUz9fPC5ilL9_jZ_4bwjLYo_PY-5CKrjcK2pH8B8y4aUUpseGeC5QdxGD4HpvRTSoslTwUXuVGrOPyUT5FHwykqwCMJv-7fHk3NWTk_ArH_nz0bfn1pJtHAWHFJAw8820rzgIbB48F3ZbiaBTfESZY29iIzi1ngqq6mDaMpINh3X7MuQq3L90K_rr&sig=AOD64_2IpBc4vty-6Tc066z47dc0zFEJ0g&adurl=https://clickserve.dartsearch.net/link/click%3Flid%3D92700057522574369%26ds_s_kwgid%3D58700006368161508%26ds_s_inventory_feed_id%3D97700000007215323%26ds_a_cid%3D2001181%26ds_a_caid%3D11205481652%26ds_a_agid%3D107178459582%26ds_a_fiid%3D%26ds_a_lid%3Dpla-477762231356%26ds_a_extid%3D%26%26ds_e_adid%3D470980643466%26ds_e_matchtype%3Dsearch%26ds_e_device%3Dc%26ds_e_network%3Dg%26ds_e_product_group_id%3D477762231356%26ds_e_product_id%3DD45Y8%26ds_e_product_merchant_id%3D15144%26ds_e_product_country%3DUS%26ds_e_product_language%3Den%26ds_e_product_channel%3Donline%26ds_e_product_store_id%3D%26ds_url_v%3D2%26ds_dest_url%3Dhttps://www.sweetwater.com/store/detail/D45Y8--martin-d-45-acoustic-guitar-natural%3Futm_source%3Dgoogle%26utm_medium%3Dorganicpla%26mrkgadid%3D%26mrkgcl%3D28%26mrkgen%3Dgpla%26mrkgbflag%3D0%26mrkgcat%3D%26acctid%3D21700000001645388%26dskeywordid%3D92700057522574369%26lid%3D92700057522574369%26ds_s_kwgid%3D58700006368161508%26ds_s_inventory_feed_id%3D97700000007215323%26dsproductgroupid%3D477762231356%26product_id%3DD45Y8%26prodctry%3DUS%26prodlang%3Den%26channel%3Donline%26storeid%3D%26device%3Dc%26network%3Dg%26matchtype%3D%26adpos%3Dlargenumber%26locationid%3D1014080%26creative%3D470980643466%26targetid%3Dpla-477762231356%26campaignid%3D11205481652%26awsearchcpc%3D1%26gclsrc%3Daw.ds%26
@fmarier fmarier added the Debounce Debouncing list related label Jul 4, 2022
@fmarier fmarier requested a review from ryanbr July 4, 2022 19:24
@fmarier fmarier self-assigned this Jul 4, 2022
@fmarier
Copy link
Member Author

fmarier commented Jul 4, 2022

I have tested locally with the above sample URL, using the procedure documented at https://github.com/brave/brave-browser/wiki/Debouncing#testing-new-rules.

@ryanbr
Copy link
Collaborator

ryanbr commented Jul 6, 2022

Is this safe and won't cause issues? We have ||googleadservices.com^$third-party not sure if that would interfere with the debounce, just being cautious @fmarier

@fmarier
Copy link
Member Author

fmarier commented Jul 6, 2022

Is this safe and won't cause issues?

Yeah, I've tested it. Like I explained in #865, this rule was never the problem.

We have ||googleadservices.com^$third-party not sure if that would interfere with the debounce

Doesn't that just block googleadservices.com sub-resources when you're on another site? In the case of a redirect, googleadservices.com is a first-party so I don't think the filter would apply.

@ryanbr ryanbr merged commit e143c1b into master Jul 6, 2022
@ryanbr ryanbr deleted the googleadservices-865 branch July 6, 2022 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Debounce Debouncing list related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restore the googleadservices.com rule
2 participants