Enhance service configuration #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also added api documentation. There are many ways to do this, but the most common I see out there is openapi standard |
|
Hi Joao! Thanks so much for the pull request! It is really appreciated. I was planning on updating this with a Dockerfile myself eventually, so you saved me some work. For part 2 of the pull request, there is already an OpenAPI 3.0 json document in the docs directory of the project. Not sure if you've noticed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, saw your post :)
Since the task was specified a micro service architecture I would recommend providing better ways for your dev ops team to configure your service. Here I provide some examples, like providing docker/docker-compose templates and injecting service configuration from environment variables.