Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Windows #19

Merged
merged 4 commits into from
Aug 13, 2024
Merged

Add support for Windows #19

merged 4 commits into from
Aug 13, 2024

Conversation

brainsik
Copy link
Owner

  • Use os.replace() instead of os.rename() to fix Windows issue
  • Adds Windows to test matrix
  • For now, shelve2json is not supported on Windows

Fixes #18

shelve.open is failing on Windows with an internal traceback. This
utility is so little used, not going to worry about it and move on.
@brainsik brainsik merged commit 41fb8b2 into main Aug 13, 2024
30 checks passed
@brainsik brainsik deleted the windows branch August 13, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

os.rename, FileExistsError: [WinError 183]
1 participant